Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Masaki Muranaka <monaka@monami-software.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: ser-mingw.c will be failed to build on GCC4.4.
Date: Thu, 25 Dec 2008 02:37:00 -0000	[thread overview]
Message-ID: <FC06CCBB-C84F-4AE1-8D8C-EAE42E36ED51@monami-software.com> (raw)
In-Reply-To: <20081224033318.GD15887@adacore.com>

Hello Joel,
Thanks for your comment.

I reviewed them after I sent mail.
Your idea is reasonable. It shut GCC4.4's warnings up.
The another solustion is to add noreturn attribute, I guess.
Anyway I'll send some patches later.

On 2008/12/24, at 12:33, Joel Brobecker wrote:

>> Some functions in ser-mingw.c is declared with return value, with no
>> return statement.  For example, console_select_thread(),
>> pipe_select_thread(), file_select_thread().
>
> All these functions are used as the initial function when creating
> threads.  According to the MS documentation, the return value is
> used to determine whether the function was successful or not.
> In our case, I think that the thing to do is to add a "return 0"
> at the end.
>
> -- 
> Joel
>

Masaki Muranaka
Monami Software





      reply	other threads:[~2008-12-25  2:37 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-24  2:25 Masaki Muranaka
2008-12-24  3:34 ` Joel Brobecker
2008-12-25  2:37   ` Masaki Muranaka [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=FC06CCBB-C84F-4AE1-8D8C-EAE42E36ED51@monami-software.com \
    --to=monaka@monami-software.com \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox