From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28644 invoked by alias); 25 Dec 2008 02:37:52 -0000 Received: (qmail 28635 invoked by uid 22791); 25 Dec 2008 02:37:51 -0000 X-SWARE-Spam-Status: No, hits=-2.6 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from mail2.asahi-net.or.jp (HELO mail.asahi-net.or.jp) (202.224.39.198) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 25 Dec 2008 02:37:12 +0000 Received: from [192.168.0.94] (p12018-ipbffx02marunouchi.tokyo.ocn.ne.jp [222.147.75.18]) by mail.asahi-net.or.jp (Postfix) with ESMTP id 2F4DF6251E; Thu, 25 Dec 2008 11:37:09 +0900 (JST) Cc: gdb-patches@sourceware.org Message-Id: From: Masaki Muranaka To: Joel Brobecker In-Reply-To: <20081224033318.GD15887@adacore.com> Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Apple Message framework v930.3) Subject: Re: ser-mingw.c will be failed to build on GCC4.4. Date: Thu, 25 Dec 2008 02:37:00 -0000 References: <49766CA5-7239-43DA-B018-5889387216FD@monami-software.com> <20081224033318.GD15887@adacore.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-12/txt/msg00409.txt.bz2 Hello Joel, Thanks for your comment. I reviewed them after I sent mail. Your idea is reasonable. It shut GCC4.4's warnings up. The another solustion is to add noreturn attribute, I guess. Anyway I'll send some patches later. On 2008/12/24, at 12:33, Joel Brobecker wrote: >> Some functions in ser-mingw.c is declared with return value, with no >> return statement. For example, console_select_thread(), >> pipe_select_thread(), file_select_thread(). > > All these functions are used as the initial function when creating > threads. According to the MS documentation, the return value is > used to determine whether the function was successful or not. > In our case, I think that the thing to do is to add a "return 0" > at the end. > > -- > Joel > Masaki Muranaka Monami Software