Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Marc Khouzam <marc.khouzam@ericsson.com>
To: "'Joel Brobecker'" <brobecker@adacore.com>
Cc: "'Pedro Alves'" <pedro@codesourcery.com>,
	       "'gdb-patches@sourceware.org'"
	<gdb-patches@sourceware.org>,
	       "'Tom Tromey'" <tromey@redhat.com>
Subject: RE: segfault: what should happen when I remove an inferior that is running?
Date: Thu, 06 Jan 2011 18:57:00 -0000	[thread overview]
Message-ID: <F7CE05678329534C957159168FA70DEC5730CFD3FC@EUSAACMS0703.eamcs.ericsson.se> (raw)
In-Reply-To: <20101223043811.GT2596@adacore.com>

> -----Original Message-----
> From: Joel Brobecker [mailto:brobecker@adacore.com] 
> Sent: Wednesday, December 22, 2010 11:38 PM
> To: Marc Khouzam
> Cc: 'Pedro Alves'; 'gdb-patches@sourceware.org'; 'Tom Tromey'
> Subject: Re: segfault: what should happen when I remove an 
> inferior that is running?
> 
> > Just a small nit that the ARI script discovered, we forgot the i18n
> > marker:
> > 
> >         error (_("cannot remore an active inferior"));
> > 
> > (I also think that the proper spelling is `cannot' rather than
> > 'can not' - confirmed by wikipedia, even though they say that it is
> > occasionally spelled as two words)
> > 
> > Would you mind making the obvious fix?
> 
> Looks like Mark is away from the office, so I checked in the attached
> fix (HEAD & 7.2 branch)

Thanks Joel!

So I know for next time, when should this i18n marker be used?  
Should it be used for any user-visible string output?  
There are other instances of error() being called without it 
from mi-main.c.

> \grep error\ \( mi-main.c | \grep -v error\ \(_ | wc -l
38


  reply	other threads:[~2011-01-06 18:57 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <F7CE05678329534C957159168FA70DEC572E0C0E1A@EUSAACMS0703.eamcs.ericsson.se>
     [not found] ` <m3oc8otms0.fsf@fleche.redhat.com>
     [not found]   ` <201012141523.51109.pedro@codesourcery.com>
2010-12-18  2:47     ` Marc Khouzam
2010-12-22 12:10       ` Pedro Alves
2010-12-22 18:32         ` Marc Khouzam
2010-12-22 18:45           ` Pedro Alves
2010-12-22 22:02             ` Marc Khouzam
2010-12-23  4:02               ` Joel Brobecker
2010-12-23  5:27                 ` Joel Brobecker
2011-01-06 18:57                   ` Marc Khouzam [this message]
2011-01-06 20:17                     ` Tom Tromey
2011-01-06 20:37                       ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=F7CE05678329534C957159168FA70DEC5730CFD3FC@EUSAACMS0703.eamcs.ericsson.se \
    --to=marc.khouzam@ericsson.com \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=pedro@codesourcery.com \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox