From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21926 invoked by alias); 6 Jan 2011 18:57:05 -0000 Received: (qmail 21916 invoked by uid 22791); 6 Jan 2011 18:57:05 -0000 X-SWARE-Spam-Status: No, hits=-1.5 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from imr4.ericy.com (HELO imr4.ericy.com) (198.24.6.8) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 06 Jan 2011 18:56:59 +0000 Received: from eusaamw0706.eamcs.ericsson.se ([147.117.20.31]) by imr4.ericy.com (8.14.3/8.14.3/Debian-9.1ubuntu1) with ESMTP id p06JWlUh003442; Thu, 6 Jan 2011 13:32:51 -0600 Received: from EUSAACMS0703.eamcs.ericsson.se ([169.254.1.66]) by eusaamw0706.eamcs.ericsson.se ([147.117.20.31]) with mapi; Thu, 6 Jan 2011 13:56:28 -0500 From: Marc Khouzam To: "'Joel Brobecker'" CC: "'Pedro Alves'" , "'gdb-patches@sourceware.org'" , "'Tom Tromey'" Date: Thu, 06 Jan 2011 18:57:00 -0000 Subject: RE: segfault: what should happen when I remove an inferior that is running? Message-ID: References: <201012221210.30198.pedro@codesourcery.com> <201012221817.17271.pedro@codesourcery.com> <20101223033332.GN2596@adacore.com> <20101223043811.GT2596@adacore.com> In-Reply-To: <20101223043811.GT2596@adacore.com> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-01/txt/msg00137.txt.bz2 > -----Original Message----- > From: Joel Brobecker [mailto:brobecker@adacore.com]=20 > Sent: Wednesday, December 22, 2010 11:38 PM > To: Marc Khouzam > Cc: 'Pedro Alves'; 'gdb-patches@sourceware.org'; 'Tom Tromey' > Subject: Re: segfault: what should happen when I remove an=20 > inferior that is running? >=20 > > Just a small nit that the ARI script discovered, we forgot the i18n > > marker: > >=20 > > error (_("cannot remore an active inferior")); > >=20 > > (I also think that the proper spelling is `cannot' rather than > > 'can not' - confirmed by wikipedia, even though they say that it is > > occasionally spelled as two words) > >=20 > > Would you mind making the obvious fix? >=20 > Looks like Mark is away from the office, so I checked in the attached > fix (HEAD & 7.2 branch) Thanks Joel! So I know for next time, when should this i18n marker be used?=20=20 Should it be used for any user-visible string output?=20=20 There are other instances of error() being called without it=20 from mi-main.c. > \grep error\ \( mi-main.c | \grep -v error\ \(_ | wc -l 38