From: Joel Brobecker <brobecker@adacore.com>
To: Marc Khouzam <marc.khouzam@ericsson.com>
Cc: 'Pedro Alves' <pedro@codesourcery.com>,
"'gdb-patches@sourceware.org'" <gdb-patches@sourceware.org>,
'Tom Tromey' <tromey@redhat.com>
Subject: Re: segfault: what should happen when I remove an inferior that is running?
Date: Thu, 23 Dec 2010 05:27:00 -0000 [thread overview]
Message-ID: <20101223043811.GT2596@adacore.com> (raw)
In-Reply-To: <20101223033332.GN2596@adacore.com>
[-- Attachment #1: Type: text/plain, Size: 464 bytes --]
> Just a small nit that the ARI script discovered, we forgot the i18n
> marker:
>
> error (_("cannot remore an active inferior"));
>
> (I also think that the proper spelling is `cannot' rather than
> 'can not' - confirmed by wikipedia, even though they say that it is
> occasionally spelled as two words)
>
> Would you mind making the obvious fix?
Looks like Mark is away from the office, so I checked in the attached
fix (HEAD & 7.2 branch)
--
Joel
[-- Attachment #2: i18n.diff --]
[-- Type: text/x-diff, Size: 1185 bytes --]
commit f114e5b6d29ff343021bb67765d209fa98d675fb
Author: Joel Brobecker <brobecker@adacore.com>
Date: Thu Dec 23 08:27:37 2010 +0400
Add missing _() marker in error message.
gdb/ChangeLog:
* mi/mi-main.c (mi_cmd_remove_inferior): Use _() marker for error
message. Change spelling of "can not" into "cannot".
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 24db449..4504f11 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2010-12-23 Joel Brobecker <brobecker@adacore.com>
+
+ * mi/mi-main.c (mi_cmd_remove_inferior): Use _() marker for error
+ message. Change spelling of "can not" into "cannot".
+
2010-12-23 Yao Qi <yao@codesourcery.com>
* arm-tdep.c (arm_gdbarch_init): Remove invoke to
diff --git a/gdb/mi/mi-main.c b/gdb/mi/mi-main.c
index 6f66e89..f713412 100644
--- a/gdb/mi/mi-main.c
+++ b/gdb/mi/mi-main.c
@@ -1773,7 +1773,7 @@ mi_cmd_remove_inferior (char *command, char **argv, int argc)
error ("the specified thread group does not exist");
if (inf->pid != 0)
- error ("can not remove an active inferior");
+ error (_("cannot remove an active inferior"));
if (inf == current_inferior ())
{
next prev parent reply other threads:[~2010-12-23 4:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <F7CE05678329534C957159168FA70DEC572E0C0E1A@EUSAACMS0703.eamcs.ericsson.se>
[not found] ` <m3oc8otms0.fsf@fleche.redhat.com>
[not found] ` <201012141523.51109.pedro@codesourcery.com>
2010-12-18 2:47 ` Marc Khouzam
2010-12-22 12:10 ` Pedro Alves
2010-12-22 18:32 ` Marc Khouzam
2010-12-22 18:45 ` Pedro Alves
2010-12-22 22:02 ` Marc Khouzam
2010-12-23 4:02 ` Joel Brobecker
2010-12-23 5:27 ` Joel Brobecker [this message]
2011-01-06 18:57 ` Marc Khouzam
2011-01-06 20:17 ` Tom Tromey
2011-01-06 20:37 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101223043811.GT2596@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=marc.khouzam@ericsson.com \
--cc=pedro@codesourcery.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox