Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Marc Khouzam <marc.khouzam@ericsson.com>
Cc: 'Pedro Alves' <pedro@codesourcery.com>,
	"'gdb-patches@sourceware.org'" <gdb-patches@sourceware.org>,
	'Tom Tromey' <tromey@redhat.com>
Subject: Re: segfault: what should happen when I remove an inferior that is running?
Date: Thu, 23 Dec 2010 04:02:00 -0000	[thread overview]
Message-ID: <20101223033332.GN2596@adacore.com> (raw)
In-Reply-To: <F7CE05678329534C957159168FA70DEC5730924C5E@EUSAACMS0703.eamcs.ericsson.se>

Mark,

> 2010-12-22  Marc Khouzam  <marc.khouzam@ericsson.com>
> 
>       * inferior.c (remove_inferior_command): Don't remove an active inferior.
>       * mi/mi-main.c (mi_cmd_remove_inferior): Ditto.
[...]
> +  if (inf->pid != 0)
> +    error ("can not remove an active inferior");

Just a small nit that the ARI script discovered, we forgot the i18n
marker:

        error (_("cannot remore an active inferior"));

(I also think that the proper spelling is `cannot' rather than
'can not' - confirmed by wikipedia, even though they say that it is
occasionally spelled as two words)

Would you mind making the obvious fix?

Thanks,
-- 
Joel


  reply	other threads:[~2010-12-23  3:33 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <F7CE05678329534C957159168FA70DEC572E0C0E1A@EUSAACMS0703.eamcs.ericsson.se>
     [not found] ` <m3oc8otms0.fsf@fleche.redhat.com>
     [not found]   ` <201012141523.51109.pedro@codesourcery.com>
2010-12-18  2:47     ` Marc Khouzam
2010-12-22 12:10       ` Pedro Alves
2010-12-22 18:32         ` Marc Khouzam
2010-12-22 18:45           ` Pedro Alves
2010-12-22 22:02             ` Marc Khouzam
2010-12-23  4:02               ` Joel Brobecker [this message]
2010-12-23  5:27                 ` Joel Brobecker
2011-01-06 18:57                   ` Marc Khouzam
2011-01-06 20:17                     ` Tom Tromey
2011-01-06 20:37                       ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101223033332.GN2596@adacore.com \
    --to=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=marc.khouzam@ericsson.com \
    --cc=pedro@codesourcery.com \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox