From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28950 invoked by alias); 23 Dec 2010 03:33:51 -0000 Received: (qmail 28942 invoked by uid 22791); 23 Dec 2010 03:33:51 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 23 Dec 2010 03:33:46 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 502CC2BACBB; Wed, 22 Dec 2010 22:33:45 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id oLdzHt8Co915; Wed, 22 Dec 2010 22:33:45 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 839102BAC9F; Wed, 22 Dec 2010 22:33:44 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id D9ACB1457B3; Thu, 23 Dec 2010 04:33:32 +0100 (CET) Date: Thu, 23 Dec 2010 04:02:00 -0000 From: Joel Brobecker To: Marc Khouzam Cc: 'Pedro Alves' , "'gdb-patches@sourceware.org'" , 'Tom Tromey' Subject: Re: segfault: what should happen when I remove an inferior that is running? Message-ID: <20101223033332.GN2596@adacore.com> References: <201012221210.30198.pedro@codesourcery.com> <201012221817.17271.pedro@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-12/txt/msg00420.txt.bz2 Mark, > 2010-12-22 Marc Khouzam > > * inferior.c (remove_inferior_command): Don't remove an active inferior. > * mi/mi-main.c (mi_cmd_remove_inferior): Ditto. [...] > + if (inf->pid != 0) > + error ("can not remove an active inferior"); Just a small nit that the ARI script discovered, we forgot the i18n marker: error (_("cannot remore an active inferior")); (I also think that the proper spelling is `cannot' rather than 'can not' - confirmed by wikipedia, even though they say that it is occasionally spelled as two words) Would you mind making the obvious fix? Thanks, -- Joel