From: "Abid, Hafiz" <Hafiz_Abid@mentor.com>
To: "Kozlov, Dmitry" <Dmitry_Kozlov@mentor.com>,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
"Shebs, Stan" <Stan_Shebs@mentor.com>
Cc: "Prus, Vladimir" <Vladimir_Prus@mentor.com>,
"Qi, Yao" <Yao_Qi@mentor.com>
Subject: RE: [PATCH] Modify trace-status output to always output stop-notes.
Date: Wed, 10 Oct 2012 12:40:00 -0000 [thread overview]
Message-ID: <EB3B29AD43CA924DA27099BC851923768C57304A@EU-MBX-02.mgc.mentorg.com> (raw)
In-Reply-To: <50755958.5090107@mentor.com>
Just a small formatting nit.
+ else if (strncmp (p, "stop-notes", p1 - p) == 0)
+ {
+ ++p1;
+ ts->stop_desc= xmalloc (strlen (p) / 2);
A space is missing before =
+ end = hex2bin (p1, ts->stop_desc, (p3 - p1) / 2);
+ ts->stop_desc[end] = '\0';
+ p = p3;
+ }
Regards,
Abid
--
Hafiz Abid Qadeer
Mentor Graphics
hafiz_abid@mentor.com
+44 161 926 1630
> -----Original Message-----
> From: gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] On Behalf Of Kozlov, Dmitry
> Sent: Wednesday, October 10, 2012 12:18 PM
> To: gdb-patches@sourceware.org; Shebs, Stan
> Cc: Prus, Vladimir; Qi, Yao
> Subject: [PATCH] Modify trace-status output to always output stop-
> notes.
>
> Hi,
> accoriding to discussion in gdb mailing list I have added stop-notes as
> mandatory part of MI trace-status command. This makes processing of
> stop-notes on IDE side more uniform with trace-notes processing.
> Previously Yao mentioned that he implemented notifications that can be
> used to monitor trace-status, but putting stop-notes to trace-status
> looks more clear way because processing one extra trace-status
> parameter defferently from others.
>
> Stan, is it ok?
>
> Thank you
next prev parent reply other threads:[~2012-10-10 12:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-10 11:18 Dmitry Kozlov
2012-10-10 12:40 ` Abid, Hafiz [this message]
2012-10-10 15:47 ` Dmitry Kozlov
2012-10-10 23:14 ` Stan Shebs
2012-10-11 0:10 ` Yao Qi
2012-10-11 15:51 ` Dmitry Kozlov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=EB3B29AD43CA924DA27099BC851923768C57304A@EU-MBX-02.mgc.mentorg.com \
--to=hafiz_abid@mentor.com \
--cc=Dmitry_Kozlov@mentor.com \
--cc=Stan_Shebs@mentor.com \
--cc=Vladimir_Prus@mentor.com \
--cc=Yao_Qi@mentor.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox