From: Yao Qi <yao@codesourcery.com>
To: Dmitry Kozlov <dmitry_kozlov@mentor.com>
Cc: <gdb-patches@sourceware.org>,
"'Stan_Shebs@mentor.com'" <Stan_Shebs@mentor.com>,
Vladimir Prus <vladimir@codesourcery.com>
Subject: Re: [PATCH] Modify trace-status output to always output stop-notes.
Date: Thu, 11 Oct 2012 00:10:00 -0000 [thread overview]
Message-ID: <50760E87.40902@codesourcery.com> (raw)
In-Reply-To: <50755958.5090107@mentor.com>
On 10/10/2012 07:17 PM, Dmitry Kozlov wrote:
> + if (ts->stop_desc)
> + {
> + char *buf = (char *) xmalloc (strlen (ts->stop_desc) * 2 + 1);
> +
> + bin2hex ((gdb_byte *) ts->stop_desc, buf, 0);
> + fprintf (fp, ";stop-notes:%s", buf);
> + }
Besides Stan's comments, the indentation here looks strange to me, and
BUF is not xfree'ed.
--
Yao
next prev parent reply other threads:[~2012-10-11 0:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-10 11:18 Dmitry Kozlov
2012-10-10 12:40 ` Abid, Hafiz
2012-10-10 15:47 ` Dmitry Kozlov
2012-10-10 23:14 ` Stan Shebs
2012-10-11 0:10 ` Yao Qi [this message]
2012-10-11 15:51 ` Dmitry Kozlov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50760E87.40902@codesourcery.com \
--to=yao@codesourcery.com \
--cc=Stan_Shebs@mentor.com \
--cc=dmitry_kozlov@mentor.com \
--cc=gdb-patches@sourceware.org \
--cc=vladimir@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox