From: Stan Shebs <stanshebs@earthlink.net>
To: gdb-patches@sourceware.org
Subject: Re: [PATCH] Modify trace-status output to always output stop-notes.
Date: Wed, 10 Oct 2012 23:14:00 -0000 [thread overview]
Message-ID: <5076013D.1060901@earthlink.net> (raw)
In-Reply-To: <50755958.5090107@mentor.com>
On 10/10/12 4:17 AM, Dmitry Kozlov wrote:
> Hi,
> accoriding to discussion in gdb mailing list I have added stop-notes
> as mandatory part of MI trace-status command. This makes processing of
> stop-notes on IDE side more uniform with trace-notes processing.
> Previously Yao mentioned that he implemented notifications that can be
> used to monitor trace-status, but putting stop-notes to trace-status
> looks more clear way because processing one extra trace-status
> parameter defferently from others.
>
> Stan, is it ok?
Yes, this just needs a couple tweaks:
+ * gdbserver/traicepoint.c (cmd_qtstatus): Modify trace-status output to
Extra 'i' ...plus gdbserver has its own ChangeLog where this piece of the entry should go.
@@ -2164,6 +2164,7 @@ trace_status_mi (int on_stop)
ui_out_field_string (uiout, "user-name", ts->user_name);
ui_out_field_string (uiout, "notes", ts->notes);
+ ui_out_field_string (uiout, "stop-notes", ts->stop_desc);
It would be useful to add a brief note to the effect that this is unconditional for the MI command, so that some future version of ourselves doesn't assume that there is a missing if-statement.
We really should have a testsuite test for this. Yao's recently-added mi-* tests in gdb.trace look like they would be good candidates to crib from.
Stan
stan@codesourcery.com
next prev parent reply other threads:[~2012-10-10 23:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-10 11:18 Dmitry Kozlov
2012-10-10 12:40 ` Abid, Hafiz
2012-10-10 15:47 ` Dmitry Kozlov
2012-10-10 23:14 ` Stan Shebs [this message]
2012-10-11 0:10 ` Yao Qi
2012-10-11 15:51 ` Dmitry Kozlov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5076013D.1060901@earthlink.net \
--to=stanshebs@earthlink.net \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox