From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29297 invoked by alias); 10 Oct 2012 23:14:37 -0000 Received: (qmail 29285 invoked by uid 22791); 10 Oct 2012 23:14:34 -0000 X-SWARE-Spam-Status: No, hits=-4.1 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,KHOP_THREADED,RCVD_IN_DNSWL_NONE,RCVD_IN_HOSTKARMA_YE,RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from elasmtp-banded.atl.sa.earthlink.net (HELO elasmtp-banded.atl.sa.earthlink.net) (209.86.89.70) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 10 Oct 2012 23:14:16 +0000 Received: from [68.96.200.16] (helo=macbook2.local) by elasmtp-banded.atl.sa.earthlink.net with esmtpa (Exim 4.67) (envelope-from ) id 1TM5Ti-0001r0-HJ for gdb-patches@sourceware.org; Wed, 10 Oct 2012 19:14:14 -0400 Message-ID: <5076013D.1060901@earthlink.net> Date: Wed, 10 Oct 2012 23:14:00 -0000 From: Stan Shebs User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:15.0) Gecko/20120907 Thunderbird/15.0.1 MIME-Version: 1.0 To: gdb-patches@sourceware.org Subject: Re: [PATCH] Modify trace-status output to always output stop-notes. References: <50755958.5090107@mentor.com> In-Reply-To: <50755958.5090107@mentor.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-ELNK-Trace: ae6f8838ff913eba0cc1426638a40ef67e972de0d01da940a602c0e8149d899af770acf9feec6c32350badd9bab72f9c350badd9bab72f9c350badd9bab72f9c X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-10/txt/msg00166.txt.bz2 On 10/10/12 4:17 AM, Dmitry Kozlov wrote: > Hi, > accoriding to discussion in gdb mailing list I have added stop-notes > as mandatory part of MI trace-status command. This makes processing of > stop-notes on IDE side more uniform with trace-notes processing. > Previously Yao mentioned that he implemented notifications that can be > used to monitor trace-status, but putting stop-notes to trace-status > looks more clear way because processing one extra trace-status > parameter defferently from others. > > Stan, is it ok? Yes, this just needs a couple tweaks: + * gdbserver/traicepoint.c (cmd_qtstatus): Modify trace-status output to Extra 'i' ...plus gdbserver has its own ChangeLog where this piece of the entry should go. @@ -2164,6 +2164,7 @@ trace_status_mi (int on_stop) ui_out_field_string (uiout, "user-name", ts->user_name); ui_out_field_string (uiout, "notes", ts->notes); + ui_out_field_string (uiout, "stop-notes", ts->stop_desc); It would be useful to add a brief note to the effect that this is unconditional for the MI command, so that some future version of ourselves doesn't assume that there is a missing if-statement. We really should have a testsuite test for this. Yao's recently-added mi-* tests in gdb.trace look like they would be good candidates to crib from. Stan stan@codesourcery.com