From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-95159-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 29423 invoked by alias); 11 Oct 2012 00:10:57 -0000
Received: (qmail 29411 invoked by uid 22791); 11 Oct 2012 00:10:56 -0000
X-SWARE-Spam-Status: No, hits=-4.5 required=5.0	tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL
X-Spam-Check-By: sourceware.org
Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 11 Oct 2012 00:10:51 +0000
Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93])	by relay1.mentorg.com with esmtp 	id 1TM6MU-0004zZ-Ja from Yao_Qi@mentor.com 	for gdb-patches@sourceware.org; Wed, 10 Oct 2012 17:10:50 -0700
Received: from SVR-ORW-FEM-02.mgc.mentorg.com ([147.34.96.206]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675);	 Wed, 10 Oct 2012 17:10:50 -0700
Received: from qiyao.dyndns.org (147.34.91.1) by svr-orw-fem-02.mgc.mentorg.com (147.34.96.168) with Microsoft SMTP Server id 14.1.289.1; Wed, 10 Oct 2012 17:10:49 -0700
Message-ID: <50760E87.40902@codesourcery.com>
Date: Thu, 11 Oct 2012 00:10:00 -0000
From: Yao Qi <yao@codesourcery.com>
User-Agent: Mozilla/5.0 (X11; Linux i686; rv:15.0) Gecko/20120911 Thunderbird/15.0.1
MIME-Version: 1.0
To: Dmitry Kozlov <dmitry_kozlov@mentor.com>
CC: <gdb-patches@sourceware.org>, "'Stan_Shebs@mentor.com'"	<Stan_Shebs@mentor.com>, Vladimir Prus <vladimir@codesourcery.com>
Subject: Re: [PATCH] Modify trace-status output to always output stop-notes.
References: <50755958.5090107@mentor.com>
In-Reply-To: <50755958.5090107@mentor.com>
Content-Type: text/plain; charset="ISO-8859-1"; format=flowed
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-10/txt/msg00167.txt.bz2

On 10/10/2012 07:17 PM, Dmitry Kozlov wrote:
> +  if (ts->stop_desc)
> +    {
> +	  char *buf = (char *) xmalloc (strlen (ts->stop_desc) * 2 + 1);
> +
> +	  bin2hex ((gdb_byte *) ts->stop_desc, buf, 0);
> +	  fprintf (fp, ";stop-notes:%s", buf);
> +   }

Besides Stan's comments, the indentation here looks strange to me, and
BUF is not xfree'ed.

-- 
Yao