From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22891 invoked by alias); 10 Oct 2012 12:40:24 -0000 Received: (qmail 22880 invoked by uid 22791); 10 Oct 2012 12:40:22 -0000 X-SWARE-Spam-Status: No, hits=-4.3 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 10 Oct 2012 12:40:16 +0000 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1TLvaC-0006VU-1t from Hafiz_Abid@mentor.com for gdb-patches@sourceware.org; Wed, 10 Oct 2012 05:40:16 -0700 Received: from SVR-IES-FEM-01.mgc.mentorg.com ([137.202.0.104]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Wed, 10 Oct 2012 05:40:15 -0700 Received: from EU-MBX-02.mgc.mentorg.com ([169.254.3.206]) by SVR-IES-FEM-01.mgc.mentorg.com ([137.202.0.104]) with mapi id 14.01.0289.001; Wed, 10 Oct 2012 13:40:14 +0100 From: "Abid, Hafiz" To: "Kozlov, Dmitry" , "gdb-patches@sourceware.org" , "Shebs, Stan" CC: "Prus, Vladimir" , "Qi, Yao" Subject: RE: [PATCH] Modify trace-status output to always output stop-notes. Date: Wed, 10 Oct 2012 12:40:00 -0000 Message-ID: References: <50755958.5090107@mentor.com> In-Reply-To: <50755958.5090107@mentor.com> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-10/txt/msg00159.txt.bz2 Just a small formatting nit. + else if (strncmp (p, "stop-notes", p1 - p) =3D=3D 0) + { + ++p1; + ts->stop_desc=3D xmalloc (strlen (p) / 2); A space is missing before =3D + end =3D hex2bin (p1, ts->stop_desc, (p3 - p1) / 2); + ts->stop_desc[end] =3D '\0'; + p =3D p3; + } Regards, Abid -- Hafiz Abid Qadeer Mentor Graphics hafiz_abid@mentor.com +44 161 926 1630 > -----Original Message----- > From: gdb-patches-owner@sourceware.org [mailto:gdb-patches- > owner@sourceware.org] On Behalf Of Kozlov, Dmitry > Sent: Wednesday, October 10, 2012 12:18 PM > To: gdb-patches@sourceware.org; Shebs, Stan > Cc: Prus, Vladimir; Qi, Yao > Subject: [PATCH] Modify trace-status output to always output stop- > notes. >=20 > Hi, > accoriding to discussion in gdb mailing list I have added stop-notes as > mandatory part of MI trace-status command. This makes processing of > stop-notes on IDE side more uniform with trace-notes processing. > Previously Yao mentioned that he implemented notifications that can be > used to monitor trace-status, but putting stop-notes to trace-status > looks more clear way because processing one extra trace-status > parameter defferently from others. >=20 > Stan, is it ok? >=20 > Thank you