Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Matt Rice <ratmice@gmail.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch] PR 12999 info macros command.
Date: Thu, 21 Jul 2011 10:22:00 -0000	[thread overview]
Message-ID: <E1QjosH-00013a-4r@fencepost.gnu.org> (raw)
In-Reply-To: <CACTLOFpFhXnxcWKLp2CHNn8mfp2_tNa=6GGdJ2Jmyzo8mS+d6w@mail.gmail.com>	(message from Matt Rice on Wed, 20 Jul 2011 15:01:10 -0700)

> Date: Wed, 20 Jul 2011 15:01:10 -0700
> From: Matt Rice <ratmice@gmail.com>
> Cc: gdb-patches@sourceware.org
> 
> Updated the docs, and the 'help' command text for 'info definitions'.
> I added @cindex macros, from debug info
> so it would be near the existing @cindex macros, user-defined

The documentation part of this patch is approved.  Thanks.

> +  add_cmd ("definitions", no_class, info_definitions_command,
> +	   _("Show all definitions of MACRO defined int the current \
> + compilation unit.\n\

"all definitions ... defined" uses the word redundantly.  Suggest to
remove the "defined" part.  Also, there's a typo ("int" should be
"in").


  reply	other threads:[~2011-07-21  8:45 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-19  9:57 Matt Rice
2011-07-19 17:29 ` Tom Tromey
2011-07-20  2:06   ` Matt Rice
2011-07-20 14:14     ` Tom Tromey
2011-07-20 17:24 ` Eli Zaretskii
2011-07-21  6:47   ` Matt Rice
2011-07-21 10:22     ` Eli Zaretskii [this message]
2011-07-21 14:07     ` Tom Tromey
2011-07-21 15:56       ` Matt Rice
2011-07-21 16:13         ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1QjosH-00013a-4r@fencepost.gnu.org \
    --to=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=ratmice@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox