From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-82478-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 26450 invoked by alias); 21 Jul 2011 08:45:12 -0000
Received: (qmail 26430 invoked by uid 22791); 21 Jul 2011 08:45:10 -0000
X-SWARE-Spam-Status: No, hits=-2.6 required=5.0	tests=AWL,BAYES_00,RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from fencepost.gnu.org (HELO fencepost.gnu.org) (140.186.70.10)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 21 Jul 2011 08:44:54 +0000
Received: from eliz by fencepost.gnu.org with local (Exim 4.71)	(envelope-from <eliz@gnu.org>)	id 1QjosH-00013a-4r; Thu, 21 Jul 2011 04:44:53 -0400
Date: Thu, 21 Jul 2011 10:22:00 -0000
Message-Id: <E1QjosH-00013a-4r@fencepost.gnu.org>
From: Eli Zaretskii <eliz@gnu.org>
To: Matt Rice <ratmice@gmail.com>
CC: gdb-patches@sourceware.org
In-reply-to:	<CACTLOFpFhXnxcWKLp2CHNn8mfp2_tNa=6GGdJ2Jmyzo8mS+d6w@mail.gmail.com>	(message from Matt Rice on Wed, 20 Jul 2011 15:01:10 -0700)
Subject: Re: [patch] PR 12999 info macros command.
Reply-to: Eli Zaretskii <eliz@gnu.org>
References: <CACTLOFot6DnZj173bQTLEqW=XzTDngjCLvpSZv4a-aCKfaLxog@mail.gmail.com>	<83oc0ovq7p.fsf@gnu.org> <CACTLOFpFhXnxcWKLp2CHNn8mfp2_tNa=6GGdJ2Jmyzo8mS+d6w@mail.gmail.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-07/txt/msg00573.txt.bz2

> Date: Wed, 20 Jul 2011 15:01:10 -0700
> From: Matt Rice <ratmice@gmail.com>
> Cc: gdb-patches@sourceware.org
> 
> Updated the docs, and the 'help' command text for 'info definitions'.
> I added @cindex macros, from debug info
> so it would be near the existing @cindex macros, user-defined

The documentation part of this patch is approved.  Thanks.

> +  add_cmd ("definitions", no_class, info_definitions_command,
> +	   _("Show all definitions of MACRO defined int the current \
> + compilation unit.\n\

"all definitions ... defined" uses the word redundantly.  Suggest to
remove the "defined" part.  Also, there's a typo ("int" should be
"in").