From: Tom Tromey <tromey@redhat.com>
To: Matt Rice <ratmice@gmail.com>
Cc: Eli Zaretskii <eliz@gnu.org>, gdb-patches@sourceware.org
Subject: Re: [patch] PR 12999 info macros command.
Date: Thu, 21 Jul 2011 14:07:00 -0000 [thread overview]
Message-ID: <m3bownybm4.fsf@fleche.redhat.com> (raw)
In-Reply-To: <CACTLOFpFhXnxcWKLp2CHNn8mfp2_tNa=6GGdJ2Jmyzo8mS+d6w@mail.gmail.com> (Matt Rice's message of "Wed, 20 Jul 2011 15:01:10 -0700")
>>>>> "Matt" == Matt Rice <ratmice@gmail.com> writes:
Matt> Updated the docs, and the 'help' command text for 'info definitions'.
Matt> I added @cindex macros, from debug info
Matt> so it would be near the existing @cindex macros, user-defined
Two more nits...
Matt> + if (! name || ! *name)
Matt> + error (_("The `info definitions' command requires a macro name as an \
Matt> +argument.\n"
Matt> + "Usage: info definitions MACRO\n"));
I think "usage" lines should be in the help text, but not in errors.
So, please remove it here.
Also, errors should not end with \n.
Matt> + add_cmd ("macros", no_class, info_macros_command,
Matt> + _("Show the definitions of all macros at LINESPEC, or the current \
Matt> +source location.\n\
Matt> +Usage: info source [LINESPEC]"),
Typo: s/source/macros/
This is ok with those changes.
Tom
next prev parent reply other threads:[~2011-07-21 14:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-19 9:57 Matt Rice
2011-07-19 17:29 ` Tom Tromey
2011-07-20 2:06 ` Matt Rice
2011-07-20 14:14 ` Tom Tromey
2011-07-20 17:24 ` Eli Zaretskii
2011-07-21 6:47 ` Matt Rice
2011-07-21 10:22 ` Eli Zaretskii
2011-07-21 14:07 ` Tom Tromey [this message]
2011-07-21 15:56 ` Matt Rice
2011-07-21 16:13 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3bownybm4.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=ratmice@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox