From: Eli Zaretskii <eliz@gnu.org>
To: Matt Rice <ratmice@gmail.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch] PR 12999 info macros command.
Date: Wed, 20 Jul 2011 17:24:00 -0000 [thread overview]
Message-ID: <83oc0ovq7p.fsf@gnu.org> (raw)
In-Reply-To: <CACTLOFot6DnZj173bQTLEqW=XzTDngjCLvpSZv4a-aCKfaLxog@mail.gmail.com>
> Date: Mon, 18 Jul 2011 23:57:25 -0700
> From: Matt Rice <ratmice@gmail.com>
>
> this patch adds 2 commands,
> info macros LINESPEC
> info definitions MACRO
Thanks. A few minor comments and a question.
> +@cindex definition, showing a macro's
That sounds awkward. Suggest "@cindex definition of a macro, showing"
instead.
> +@item info macros @var{linespec}
> +Show all macro definitions at the location of @var{linespec}, and describe the
Suggest a slight rewording:
Show all macro definitions that are in effect at the location
specified by @var{linespec}, and describe ...
> +@cindex definition, showing a macro's
It's not useful to have identical index entries so close to one
another. I suggest to remove the second one.
> +Show all definitions of the macro named @var{macro}, in the current scope,
It might be better to say "... definitions of the named @var{macro} ...".
Also, what is the "scope" of a macro?
next prev parent reply other threads:[~2011-07-20 17:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-19 9:57 Matt Rice
2011-07-19 17:29 ` Tom Tromey
2011-07-20 2:06 ` Matt Rice
2011-07-20 14:14 ` Tom Tromey
2011-07-20 17:24 ` Eli Zaretskii [this message]
2011-07-21 6:47 ` Matt Rice
2011-07-21 10:22 ` Eli Zaretskii
2011-07-21 14:07 ` Tom Tromey
2011-07-21 15:56 ` Matt Rice
2011-07-21 16:13 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83oc0ovq7p.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=ratmice@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox