From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-82457-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 7173 invoked by alias); 20 Jul 2011 17:04:32 -0000
Received: (qmail 7164 invoked by uid 22791); 20 Jul 2011 17:04:31 -0000
X-SWARE-Spam-Status: No, hits=-1.0 required=5.0	tests=AWL,BAYES_00,SPF_SOFTFAIL
X-Spam-Check-By: sourceware.org
Received: from mtaout20.012.net.il (HELO mtaout20.012.net.il) (80.179.55.166)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 20 Jul 2011 17:04:17 +0000
Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0LON0060062FT500@a-mtaout20.012.net.il> for gdb-patches@sourceware.org; Wed, 20 Jul 2011 20:04:07 +0300 (IDT)
Received: from HOME-C4E4A596F7 ([84.229.133.66]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LON0065W62USI10@a-mtaout20.012.net.il>; Wed, 20 Jul 2011 20:04:07 +0300 (IDT)
Date: Wed, 20 Jul 2011 17:24:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [patch] PR 12999 info macros command.
In-reply-to: <CACTLOFot6DnZj173bQTLEqW=XzTDngjCLvpSZv4a-aCKfaLxog@mail.gmail.com>
To: Matt Rice <ratmice@gmail.com>
Cc: gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <83oc0ovq7p.fsf@gnu.org>
References: <CACTLOFot6DnZj173bQTLEqW=XzTDngjCLvpSZv4a-aCKfaLxog@mail.gmail.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-07/txt/msg00552.txt.bz2

> Date: Mon, 18 Jul 2011 23:57:25 -0700
> From: Matt Rice <ratmice@gmail.com>
> 
> this patch adds 2 commands,
> info macros LINESPEC
> info definitions MACRO

Thanks.  A few minor comments and a question.

> +@cindex definition, showing a macro's

That sounds awkward.  Suggest "@cindex definition of a macro, showing"
instead.

> +@item info macros @var{linespec}
> +Show all macro definitions at the location of @var{linespec}, and describe the

Suggest a slight rewording:

  Show all macro definitions that are in effect at the location
  specified by @var{linespec}, and describe ...

> +@cindex definition, showing a macro's

It's not useful to have identical index entries so close to one
another.  I suggest to remove the second one.

> +Show all definitions of the macro named @var{macro}, in the current scope,

It might be better to say "... definitions of the named @var{macro} ...".

Also, what is the "scope" of a macro?