RE: [RFC PATCH] gdb, rsp: clarify a 0-length memory access

["Aktemur, Tankut Baris" <tankut.baris.aktemur@intel.com>]

Hi Tom,

On Thursday, March 21, 2024 5:49 PM, Eli Zaretskii wrote:
> > From: Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
> > Date: Thu, 21 Mar 2024 14:30:18 +0100
> >
> > Currently GDB uses a 0-length write access to probe for the 'X' packet
> > support.  However, it is not clear from the document what a 0-length
> > read or write attempt should do.  Clarify the document that it is
> > an error.  Also update gdbserver's implementation to return an error.
> >
> > Note that for probing, returning an error is fine.  It successfully
> > shows that the packet is supported.
> >
> > Regression-tested on X86-64 Linux using the default (unix) and
> > native-extended-gdbserver board files.
> > ---
> >  gdb/doc/gdb.texinfo | 9 +++++++++
> >  gdbserver/target.cc | 9 ++++++---
> >  2 files changed, 15 insertions(+), 3 deletions(-)
> 
> Thanks, the documentation part is okay.
> 
> Reviewed-By: Eli Zaretskii <eliz@gnu.org>

Would the code parts be ok?  This is based on the discussion we had stemming
from the 'x' packet.

Thanks
-Baris


Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva  
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928