Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Aktemur, Tankut Baris" <tankut.baris.aktemur@intel.com>
To: Andrew Burgess <aburgess@redhat.com>,
	"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Cc: Tom Tromey <tom@tromey.com>
Subject: RE: [RFC PATCH] gdb, rsp: clarify a 0-length memory access
Date: Thu, 28 Mar 2024 15:31:34 +0000	[thread overview]
Message-ID: <DM4PR11MB7303A405073CD1260719DAD0C43B2@DM4PR11MB7303.namprd11.prod.outlook.com> (raw)
In-Reply-To: <87jzlm4f7v.fsf@redhat.com>

On Thursday, March 28, 2024 3:13 PM, Andrew Burgess wrote:
> Tankut Baris Aktemur <tankut.baris.aktemur@intel.com> writes:
> 
> > Currently GDB uses a 0-length write access to probe for the 'X' packet
> > support.  However, it is not clear from the document what a 0-length
> > read or write attempt should do.  Clarify the document that it is
> > an error.  Also update gdbserver's implementation to return an error.
> 
> We're usually pretty conservative about changing existing remote
> protocol behaviour.
> 
> If I understand the current behaviour correctly, we treat the zero
> length access as always succeeding, but you propose to change this to
> always fail.
> 
> What's the motivation for this change?  Does the existing behaviour
> cause some problem?
> 
> Usually, when the docs are ambiguous we update the docs to reflect GDB's
> current behaviour, unless the current behaviour is clearly wrong.
> 
> Thanks,
> Andrew

Hi Andrew,

The background of the submission is the thread linked below, where Tom expressed
his tendency to think that a 0-length access should be an error:

https://sourceware.org/pipermail/gdb-patches/2024-March/207411.html

Thanks
-Baris


Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva  
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928


  reply	other threads:[~2024-03-28 15:32 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-21 13:30 Tankut Baris Aktemur
2024-03-21 16:48 ` Eli Zaretskii
2024-03-28  9:56   ` Aktemur, Tankut Baris
2024-03-28 14:13 ` Andrew Burgess
2024-03-28 15:31   ` Aktemur, Tankut Baris [this message]
2024-04-05 13:10     ` Andrew Burgess
2024-04-09  6:39       ` Aktemur, Tankut Baris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM4PR11MB7303A405073CD1260719DAD0C43B2@DM4PR11MB7303.namprd11.prod.outlook.com \
    --to=tankut.baris.aktemur@intel.com \
    --cc=aburgess@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox