From: Eli Zaretskii <eliz@gnu.org>
To: Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFC PATCH] gdb, rsp: clarify a 0-length memory access
Date: Thu, 21 Mar 2024 18:48:39 +0200 [thread overview]
Message-ID: <86v85f1qfs.fsf@gnu.org> (raw)
In-Reply-To: <20240321133018.602537-1-tankut.baris.aktemur@intel.com> (message from Tankut Baris Aktemur on Thu, 21 Mar 2024 14:30:18 +0100)
> From: Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
> Date: Thu, 21 Mar 2024 14:30:18 +0100
>
> Currently GDB uses a 0-length write access to probe for the 'X' packet
> support. However, it is not clear from the document what a 0-length
> read or write attempt should do. Clarify the document that it is
> an error. Also update gdbserver's implementation to return an error.
>
> Note that for probing, returning an error is fine. It successfully
> shows that the packet is supported.
>
> Regression-tested on X86-64 Linux using the default (unix) and
> native-extended-gdbserver board files.
> ---
> gdb/doc/gdb.texinfo | 9 +++++++++
> gdbserver/target.cc | 9 ++++++---
> 2 files changed, 15 insertions(+), 3 deletions(-)
Thanks, the documentation part is okay.
Reviewed-By: Eli Zaretskii <eliz@gnu.org>
next prev parent reply other threads:[~2024-03-21 16:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-21 13:30 Tankut Baris Aktemur
2024-03-21 16:48 ` Eli Zaretskii [this message]
2024-03-28 9:56 ` Aktemur, Tankut Baris
2024-03-28 14:13 ` Andrew Burgess
2024-03-28 15:31 ` Aktemur, Tankut Baris
2024-04-05 13:10 ` Andrew Burgess
2024-04-09 6:39 ` Aktemur, Tankut Baris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86v85f1qfs.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=tankut.baris.aktemur@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox