From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id ZjGWJNw+BWaPURkAWB0awg (envelope-from ) for ; Thu, 28 Mar 2024 05:56:44 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=Eo6DmZgu; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 8089C1E0C0; Thu, 28 Mar 2024 05:56:44 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 29DEC1E030 for ; Thu, 28 Mar 2024 05:56:42 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 7740C3858C31 for ; Thu, 28 Mar 2024 09:56:41 +0000 (GMT) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.14]) by sourceware.org (Postfix) with ESMTPS id 8DAE93858D20 for ; Thu, 28 Mar 2024 09:56:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8DAE93858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=intel.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 8DAE93858D20 Authentication-Results: server2.sourceware.org; arc=fail smtp.remote-ip=198.175.65.14 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1711619778; cv=fail; b=ION/E6O3BOOCu1d+vSTD1SKDt4IffK1BgHBg5NGNwqYvMQc8GfhPrRk2ZEqUwsucWXXTyad9b06cC6zex1sO8LjOoN2iQ3GKdTaYzkIDYhqH1cGyftXK9oXMFDQZXO+g8r1WyX9eSCay0pwhzuv5vteFtrJV3DSG9SOAvqtSKHg= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1711619778; c=relaxed/simple; bh=Buu5PHVokzL8Vk5XZb1QRhhZVwXmSojUOXPWEoR2KAQ=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=DW6voEDf5AqAvU4IRvO3/X6LzojvEoKYOUWBfBL3giiiTq4nXeDMMeqOlI9CO0d3Hsk7CyCBrep97z9xjmzNguqAXGbOzrGMqZFTymcZudvPlUq2pF6riuVXzBLo/yvZ/q2xHDrGiQzlx4igNWbFB31hV5I8ChQKIam1OA9WqYk= ARC-Authentication-Results: i=2; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1711619774; x=1743155774; h=from:to:cc:subject:date:message-id:references: in-reply-to:mime-version:content-transfer-encoding; bh=Buu5PHVokzL8Vk5XZb1QRhhZVwXmSojUOXPWEoR2KAQ=; b=Eo6DmZguadszO4pVDUGJ6yzsE3DSr4U1womVPvaPE6U+eJKgEEAcuVA+ 78rPeKNjpd292nyfDCmUpZSXM2gfZgswfWEmBuX/2FVTDRoooDNvqW/gz qHTclnc71IPUmoUxWy2sX+LAgnW/ChZMLz7wxNNJs9K8YMAH0yunpRvxt sIIOrMpQ6hjYKIBaeN7W49LP50wtwQCkl8lag2zpqSe2XiA3Jw/QR5F7V ux/RB/AuFO4FR+YJ3NJImMhCGEfItgGbve+0+rZTmTHN7psKLC1ybLH7Q O7rS/nXTuhPUOVWl5DJUWbCcfzLdfdNHAVmudXqHKoeyWjgmMG2W4lG8c g==; X-CSE-ConnectionGUID: QCo/0VMuQWebpcPghT05gg== X-CSE-MsgGUID: ynGjfajmQWS4ddztiyIJHQ== X-IronPort-AV: E=McAfee;i="6600,9927,11026"; a="10557941" X-IronPort-AV: E=Sophos;i="6.07,161,1708416000"; d="scan'208";a="10557941" Received: from orviesa007.jf.intel.com ([10.64.159.147]) by orvoesa106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Mar 2024 02:56:13 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,161,1708416000"; d="scan'208";a="17007767" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orviesa007.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 28 Mar 2024 02:56:13 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 28 Mar 2024 02:56:11 -0700 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 28 Mar 2024 02:56:11 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Thu, 28 Mar 2024 02:56:11 -0700 Received: from NAM04-MW2-obe.outbound.protection.outlook.com (104.47.73.168) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Thu, 28 Mar 2024 02:56:11 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kbivEY78MAp9eYw67ACtR0xPwBITMuYCMP7/tp7u5D/aTRBzGJx88Ftgc62NzjHCNDWMM2Yc7LSIndeKj+COWP8qJLQywde3I7qcMSspHk7LfjQAjwQNa2TaZK5MEc++IKJRlHe+rnKdz5n/ulIuqz2JrOc7xiCRSfaT/m7c+mA1oKWlePg+Gk+gacwDyxH1bwJJfeY7cW6mUEHKoSq0MDFwB4NchEnlLMGVU23NJFYTX4EwVtIdt0tQx57NFgvLMcezlLJ+I3R7vUhu7f6JIQjMx7w1ly6qmfM/HWrN4wmK6b8s9MZIIodrHP1pWyqRSRhB/UyyKi92OPxDK9Yt6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=s/40MYytJf5ZjNv/vE2BxGJ8Jy9+bRDtaudn1G+RDTE=; b=keN9DGEKvQsieB8gYEtTxxp+3cKx9jZMWSgcllvRc/kPhQDAFaDvHQs5Vvkpoiram6fZP3nc0FQ7D2yMMUYilbheH+Ue2Ldfkl2aXKh1CpMl4oa4tjzlZQZ00xkGMnXrtUGB06UC0mm/h8c8ytA0LqOFDJA+xIhPy6oohx8v+PYDh1WQdurjvzXao6gN5HRbfEJCW8KdwIvv7AsTUFVh4UjnWnWInXfvxMqC7AxlyO7PmayGSTjF0zm0OHV3xz34fD5Acj+n56HE9KRIjhDFiMGxuT8SUSKxDnjnbE4elyXGJ965AzUjgeHs7mhFRWYzVGT97EZbAHsAbY+ErmW5MA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM4PR11MB7303.namprd11.prod.outlook.com (2603:10b6:8:108::21) by SA0PR11MB4544.namprd11.prod.outlook.com (2603:10b6:806:92::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.32; Thu, 28 Mar 2024 09:56:09 +0000 Received: from DM4PR11MB7303.namprd11.prod.outlook.com ([fe80::9c92:b02a:3add:529e]) by DM4PR11MB7303.namprd11.prod.outlook.com ([fe80::9c92:b02a:3add:529e%5]) with mapi id 15.20.7409.031; Thu, 28 Mar 2024 09:56:09 +0000 From: "Aktemur, Tankut Baris" To: Tom Tromey , "gdb-patches@sourceware.org" CC: Eli Zaretskii Subject: RE: [RFC PATCH] gdb, rsp: clarify a 0-length memory access Thread-Topic: [RFC PATCH] gdb, rsp: clarify a 0-length memory access Thread-Index: AQHae5P97Bt70e8XK0WzwXRPCk6ObrFCaCW5gAqMalA= Date: Thu, 28 Mar 2024 09:56:09 +0000 Message-ID: References: <20240321133018.602537-1-tankut.baris.aktemur@intel.com> <86v85f1qfs.fsf@gnu.org> In-Reply-To: <86v85f1qfs.fsf@gnu.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR11MB7303:EE_|SA0PR11MB4544:EE_ x-ms-office365-filtering-correlation-id: 1d897977-0245-4f2b-c5a2-08dc4f0d4b62 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ZIoSxDaaH6POHQ5cG83YCfHZvss0UZGxjWdBC1n5pFcroG88BAkrokTyEMofYGV4rJ/lQbqUIImorwI3dDm4lepxgfZhjeeR6yrKAZ7w5XxHb+zAF0Ho+vzumtuAn+WBArCP8i8RD4daljqnduqjAS7RIQWEowM1ZFkbqx3nZOKa4SExUVrMVwwhIAZJ+iDetAGEpbH2Gv1ftTRa8vYfT2iHyfUEiCF5HLUhUmjIy1W9lKu12cBeZXQ7lo8dYO2E1nsrzFOVm9L+ncg4oYKm7prcFGY2EiMsVp5o5F8hYcTT4HnF/OB0o2zMphHc5s3OwiUtU46fnY61F7I2BdN5/QCfhDCxiPKaggPubW7LwUnPw6aGzrBh2ysESZNM9slHi6Gu7ID065YHx9c0RNGwEBSs/19YUYkBs8TkNmJ578uu7DJm+i2Ci9ihR3Er/FtEWNwhZEatWiUee1Miplv3FmHwF78sBkJy7ijPqx0HtgIkD1mKpOoJZ8PekOqzHWQqBCTJVlKb88cCM2OMh7yNApoWNs0CxpT4rsJkPTE9xBAVg4Cflm0ed41ouDmBb33hq4P9bT5my3otLWdWxGPAmcEOmRob9e53zXOXlJKcOKoDVFlsBzsB8bqwqTzm8NmWijA/YgrHzOKGjc5YyMmTIn7eKNp8j1izxCLTwMcq747nB5VNN9Zl6637XbZOWBXxRVWitEXiQHtzHXdEkUG/kQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB7303.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(366007)(1800799015)(376005)(38070700009); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?poGl63McXDwSIgxBMcMuk5QVn3SX/fM3cgw2sZ2gkgZn43gL6ObT+Nn2pJZS?= =?us-ascii?Q?6tqMuVoc+AmlR60G0BKjptz/70YEjl3Sq+HVvCN27PSw51mHbDdv71tEN+8Q?= =?us-ascii?Q?EuqHTUd8cFiKyIi0riJXPRz1PacxcGYWkxcVSnKftM88FdBzfCwoUO63L/Be?= =?us-ascii?Q?jjos3ODP08/QWb5LC4y2iFT8FNKcgFsMwVLGZo+zOM1oCHPuYOK2PnOOTq3+?= =?us-ascii?Q?cqjbRoDwALSkbzt3siX381CsWfBBFHL7QAcJAByGcHYx4t2TA7mPEIQwb0tQ?= =?us-ascii?Q?Gk/PlOpVBQzvhYKD2qJAW/0S4R+gJy+tSTBq+l2ccR7msel3JQmyMQi4Cs0b?= =?us-ascii?Q?uLR+DQ7CuH46vLyGZkjmU8trebKfNckE7ISFTOtfE2zpzw+Mb62htRjVRBEP?= =?us-ascii?Q?mTJbct68lVRuaKoEdHM++a4UjrtXaKaZdN4n7wPDENwNJJTjhmFJkajnNUBF?= =?us-ascii?Q?awdyni2sY6EaFDiyF7FvFV47uqafGQTcFhYJef5+gEcgMw4ne6s9ebpwcutv?= =?us-ascii?Q?H0NcWaOwnAkXSCUlmR90YLmlpg7As2tKQS5uWiPIdc/otK5Jl1NN9Qk363Ps?= =?us-ascii?Q?RBWtecYcafqPKi0UQS1INuyTA7A9U3wXOkdyGx+EdZzAknhpDtYYtcCLMKKp?= =?us-ascii?Q?oKYnk6LalSTlRbVJo9hwMqSoP0EYTDPtuRNMgoCOisH0P47NrgRV7qXwu3I6?= =?us-ascii?Q?YXjRmpIFmFDVVTKosnMSC60RgbinDzloiyRuc4VykfNtgKFDWYj/yNL1P0BQ?= =?us-ascii?Q?TUqcwD4vANpKaRHRibX9vERe+k22nfFY8DR7Y53IuRaooEWiw/W3wf2OToNT?= =?us-ascii?Q?Ehk0aMgEDbr7DOMo7xiyQctc3bN0Y+t668KDde1fxYPXkk98RuPiBO2cduEa?= =?us-ascii?Q?ZQvjWBWTqpxLuWX/ycll/t74eTCYA8qRYkiOrItJtFRQ+gL3xeer5JmFvrlW?= =?us-ascii?Q?59TfN7JWK7v/lyed1KkjCJ9nhrdx4P++H73ZUKqXMeHM9i+WJp51/7X2LBGP?= =?us-ascii?Q?G05uhRwaF1JkdCbCHjijYdyTX8W82cRNLWK+YVsAhrnzErjsiBeGe/JBs8kw?= =?us-ascii?Q?pXS8AKIDX81/zCQ52f2kW3xzg2gM6Yl3IIq2C25a0jWKVvMgZkY4lv41BW1/?= =?us-ascii?Q?pWgBkRYcXu0FRsCYd9rZiZCuemqCoJVNeq6yVAfYxIW/BtgQuIyZaaOBPcK3?= =?us-ascii?Q?wc9ejs/6uaghtuRa2KcBrlq8oJIbtrDyilKRPPxcneeq9WvCKeBhIWQ8tN9n?= =?us-ascii?Q?mDN3drC6i3zpX9tLVNRoZygt5fWpSF3Kqf3EpRLee29M7K0S2lWH+X22OXEm?= =?us-ascii?Q?tGu0ts6DBY1g7LsvPmZBFPm176RU8V6D3TzIPmk0HuQ2Le0WBtHdO0ts4N+z?= =?us-ascii?Q?0rJUqa/hsey44bJp/4+TUt7nVMSK4W8QkRqjlMRy/0a8nlmmbaJ6Pn/Kt6mQ?= =?us-ascii?Q?Tqx7usN9301rrZIg6wWz2z5BVpHsHPRVcllNLgpmPCHIDe6XH7z4rVnDzVNC?= =?us-ascii?Q?2X/rdBk433iwqLnKF+cqCbyCkUtzAHFHeMIsH/wRYkJxTQGyz5avM88fd2kS?= =?us-ascii?Q?d2fAL9pRSp66K9U8d3t6Ursz7/wJWNFtHPMdQ2LS4WIp6nkd+Vg5BK+QSGMP?= =?us-ascii?Q?CA=3D=3D?= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB7303.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1d897977-0245-4f2b-c5a2-08dc4f0d4b62 X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Mar 2024 09:56:09.7475 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: B9832xmsryGZ8WknbNV8Q6JqWVTNjTEPNQ+1uDnYhi+MGJ7hIQ8Ft8mO5VbOp/dkYFwxbTsAcOeAweXVXlUh4d0rd1GuX40Yeai/YzWG8PM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR11MB4544 X-OriginatorOrg: intel.com Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-6.0 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Hi Tom, On Thursday, March 21, 2024 5:49 PM, Eli Zaretskii wrote: > > From: Tankut Baris Aktemur > > Date: Thu, 21 Mar 2024 14:30:18 +0100 > > > > Currently GDB uses a 0-length write access to probe for the 'X' packet > > support. However, it is not clear from the document what a 0-length > > read or write attempt should do. Clarify the document that it is > > an error. Also update gdbserver's implementation to return an error. > > > > Note that for probing, returning an error is fine. It successfully > > shows that the packet is supported. > > > > Regression-tested on X86-64 Linux using the default (unix) and > > native-extended-gdbserver board files. > > --- > > gdb/doc/gdb.texinfo | 9 +++++++++ > > gdbserver/target.cc | 9 ++++++--- > > 2 files changed, 15 insertions(+), 3 deletions(-) > = > Thanks, the documentation part is okay. > = > Reviewed-By: Eli Zaretskii Would the code parts be ok? This is based on the discussion we had stemming from the 'x' packet. Thanks -Baris Intel Deutschland GmbH Registered Address: Am Campeon 10, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva = Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928