Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Gerlicher, Klaus" <klaus.gerlicher@intel.com>
To: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
	Tom Tromey <tom@tromey.com>
Subject: [PATCH v6 0/6] gdb: refine scheduler locking settings
Date: Tue, 3 Mar 2026 08:15:58 +0000	[thread overview]
Message-ID: <DM3PPFD7E67F036F226DD4221D6EF7A9379E87FA@DM3PPFD7E67F036.namprd11.prod.outlook.com> (raw)
In-Reply-To: <DM3PPFD7E67F0360D8623D16CE6B8DB8C63E86DA@DM3PPFD7E67F036.namprd11.prod.outlook.com>

[-- Attachment #1: Type: text/plain, Size: 5422 bytes --]

Hi,

Kindly pinging.

Thanks
Klaus

> -----Original Message-----
> From: Gerlicher, Klaus <klaus.gerlicher@intel.com>
> Sent: Tuesday, February 17, 2026 10:04 AM
> To: gdb-patches@sourceware.org; Tom Tromey <tom@tromey.com>
> Subject: RE: [PATCH v6 0/6] gdb: refine scheduler locking settings
> 
> Hi,
> 
> Kindly pinging on this series. I'll correct the doc issues in the next version once
> remaining patches are fine.
> 
> Thanks
> Klaus
> 
> 
> > -----Original Message-----
> > From: Klaus Gerlicher <klaus.gerlicher@intel.com>
> > Sent: Wednesday, February 4, 2026 2:38 PM
> > To: gdb-patches@sourceware.org
> > Subject: [PATCH v6 0/6] gdb: refine scheduler locking settings
> >
> > Hi,
> >
> > This is version 6 of the patch series to refine scheduler locking
> > settings in GDB.
> >
> > Previous versions:
> >   V5: https://inbox.sourceware.org/gdb-
> > patches/20260129095918.2216661-1-klaus.gerlicher@intel.com/
> >   V4: https://inbox.sourceware.org/gdb-
> > patches/20251205135851.2581702-1-klaus.gerlicher@intel.com/
> >   V3: https://inbox.sourceware.org/gdb-
> patches/20250811132321.486911-
> > 1-klaus.gerlicher@intel.com/
> >
> > Changes since V5:
> > -----------------
> >
> > Addressed V5 review feedback from Eli Zaretskii and Tom Tromey:
> >
> >   * Fixed spacing in NEWS file (patches 5/6 and 6/6):
> >     - Added two spaces between sentences per GNU documentation
> standards
> >     - Line wrapping improvements for readability
> >
> >   * Simplified documentation in gdb.texinfo (patches 5/6 and 6/6):
> >     - Added unified introduction explaining what "scheduler is locked" means
> >       before the list of options
> >     - Changed verbose descriptions to concise "Applies to..." format for
> >       continue, replay continue, replay step, and step options
> >     - Removed repetitive explanations while keeping the essential information
> >     - Example: "Applies to continuing commands during replay mode."
> >       instead of repeating the full "When @code{on}, the scheduler is locked..."
> >       explanation in each section
> >
> >   * Fixed code formatting in infrun.c (patches 5/6 and 6/6):
> >     - Improved formatting of schedlock_applies() call in
> >       user_visible_resume_ptid() function
> >     - Changed awkward multi-line split to properly aligned parameters:
> >         else if (schedlock_applies (step,
> >                                     target_record_will_replay (...),
> >                                     tp))
> >
> >   * Minor documentation fixes in gdb.texinfo:
> >     - Changed "e.g.@" to "e.g.@:" for proper Texinfo formatting
> >     - Changed "will not take effect" to "may not take effect" for accuracy
> >
> > Approval status:
> >   Patch 1/6: Approved-By: Tom Tromey <tom@tromey.com>
> >              https://inbox.sourceware.org/gdb-
> > patches/87a4xu9733.fsf@tromey.com/
> >
> >   Patch 2/6: (unchanged from V5, no review comments)
> >              https://inbox.sourceware.org/gdb-
> > patches/20260129095918.2216661-3-klaus.gerlicher@intel.com/
> >
> >   Patch 3/6: Approved-By: Tom Tromey <tom@tromey.com>
> >              https://inbox.sourceware.org/gdb-
> > patches/875x8i970d.fsf@tromey.com/
> >
> >   Patch 4/6: (unchanged from V5, no review comments)
> >              https://inbox.sourceware.org/gdb-
> > patches/20260129095918.2216661-5-klaus.gerlicher@intel.com/
> >
> >   Patch 5/6: Reviewed-By: Eli Zaretskii <eliz@gnu.org> (documentation parts)
> >              https://inbox.sourceware.org/gdb-patches/86ttb4t6kz.fsf@gnu.org/
> >              Changes: documentation improvements, formatting fixes
> >
> >   Patch 6/6: Reviewed-By: Eli Zaretskii <eliz@gnu.org> (documentation parts)
> >              https://inbox.sourceware.org/gdb-patches/86ldx8t6ex.fsf@gnu.org/
> >              Changes: documentation improvements, formatting fixes
> >
> >   Overall series: Reviewed-By: Guinevere Larsen <guinevere@redhat.com>
> >                   https://inbox.sourceware.org/gdb-patches/bc6fd851-29c1-436e-
> > a833-a53c0cf5a18d@redhat.com/
> >
> > Thanks to all reviewers for their thorough feedback throughout the
> > v3, v4, and v5 iterations.
> >
> > Best regards,
> > Klaus
> >
> > Natalia Saiapova (6):
> >   gdb: use schedlock_applies in user_visible_resume_ptid.
> >   gdb, cli: remove left-over code from "set_logging_on".
> >   gdb, cli: pass the argument of a set command to its callback.
> >   gdb: change the internal representation of scheduler locking.
> >   gdb: refine commands to control scheduler locking.
> >   gdb: add eval option to lock the scheduler during infcalls.
> >
> >  gdb/NEWS                                      |  26 ++
> >  gdb/cli/cli-logging.c                         |   5 -
> >  gdb/cli/cli-setshow.c                         |   2 +-
> >  gdb/doc/gdb.texinfo                           |  77 +++-
> >  gdb/infrun.c                                  | 414 +++++++++++++++---
> >  .../gdb.mi/user-selected-context-sync.exp     |  23 +-
> >  .../gdb.threads/hand-call-in-threads.exp      |  12 +-
> >  .../multiple-successive-infcall.exp           |   7 +-
> >  gdb/testsuite/gdb.threads/schedlock.exp       | 105 ++++-
> >  gdb/testsuite/lib/gdb.exp                     |  71 ++-
> >  10 files changed, 621 insertions(+), 121 deletions(-)
> >
> > --
> > 2.34.1


[-- Attachment #2.1: Type: text/plain, Size: 329 bytes --]

Intel Deutschland GmbH
Registered Address: Dornacher Straße 1, 85622 Feldkirchen, Germany
Tel: +49 89 991 430, www.intel.de
Managing Directors: Harry Demas, Jeffrey Schneiderman, Yin Chong Sorrell
Chairperson of the Supervisory Board: Nicole Lau
Registered Seat: Munich
Commercial Register: Amtsgericht München HRB 186928

[-- Attachment #2.2: Type: text/html, Size: 387 bytes --]

      reply	other threads:[~2026-03-03  8:16 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-04 13:37 Klaus Gerlicher
2026-02-04 13:37 ` [PATCH v6 1/6] gdb: use schedlock_applies in user_visible_resume_ptid Klaus Gerlicher
2026-02-04 13:37 ` [PATCH v6 2/6] gdb, cli: remove left-over code from "set_logging_on" Klaus Gerlicher
2026-02-04 14:13   ` Gerlicher, Klaus
2026-02-04 13:37 ` [PATCH v6 3/6] gdb, cli: pass the argument of a set command to its callback Klaus Gerlicher
2026-02-04 13:37 ` [PATCH v6 4/6] gdb: change the internal representation of scheduler locking Klaus Gerlicher
2026-02-04 13:37 ` [PATCH v6 5/6] gdb: refine commands to control " Klaus Gerlicher
2026-02-04 14:25   ` Eli Zaretskii
2026-02-04 13:37 ` [PATCH v6 6/6] gdb: add eval option to lock the scheduler during infcalls Klaus Gerlicher
2026-02-04 14:22   ` Eli Zaretskii
2026-02-17  9:03 ` [PATCH v6 0/6] gdb: refine scheduler locking settings Gerlicher, Klaus
2026-03-03  8:15   ` Gerlicher, Klaus [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM3PPFD7E67F036F226DD4221D6EF7A9379E87FA@DM3PPFD7E67F036.namprd11.prod.outlook.com \
    --to=klaus.gerlicher@intel.com \
    --cc=gdb-patches@sourceware.org \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox