[PATCH v6 0/6] gdb: refine scheduler locking settings

[Klaus Gerlicher <klaus.gerlicher@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 4210 bytes --]

Hi,

This is version 6 of the patch series to refine scheduler locking
settings in GDB.

Previous versions:
  V5: https://inbox.sourceware.org/gdb-patches/20260129095918.2216661-1-klaus.gerlicher@intel.com/
  V4: https://inbox.sourceware.org/gdb-patches/20251205135851.2581702-1-klaus.gerlicher@intel.com/
  V3: https://inbox.sourceware.org/gdb-patches/20250811132321.486911-1-klaus.gerlicher@intel.com/

Changes since V5:
-----------------

Addressed V5 review feedback from Eli Zaretskii and Tom Tromey:

  * Fixed spacing in NEWS file (patches 5/6 and 6/6):
    - Added two spaces between sentences per GNU documentation standards
    - Line wrapping improvements for readability

  * Simplified documentation in gdb.texinfo (patches 5/6 and 6/6):
    - Added unified introduction explaining what "scheduler is locked" means
      before the list of options
    - Changed verbose descriptions to concise "Applies to..." format for
      continue, replay continue, replay step, and step options
    - Removed repetitive explanations while keeping the essential information
    - Example: "Applies to continuing commands during replay mode."
      instead of repeating the full "When @code{on}, the scheduler is locked..."
      explanation in each section

  * Fixed code formatting in infrun.c (patches 5/6 and 6/6):
    - Improved formatting of schedlock_applies() call in
      user_visible_resume_ptid() function
    - Changed awkward multi-line split to properly aligned parameters:
        else if (schedlock_applies (step,
                                    target_record_will_replay (...),
                                    tp))

  * Minor documentation fixes in gdb.texinfo:
    - Changed "e.g.@" to "e.g.@:" for proper Texinfo formatting
    - Changed "will not take effect" to "may not take effect" for accuracy

Approval status:
  Patch 1/6: Approved-By: Tom Tromey <tom@tromey.com>
             https://inbox.sourceware.org/gdb-patches/87a4xu9733.fsf@tromey.com/

  Patch 2/6: (unchanged from V5, no review comments)
             https://inbox.sourceware.org/gdb-patches/20260129095918.2216661-3-klaus.gerlicher@intel.com/

  Patch 3/6: Approved-By: Tom Tromey <tom@tromey.com>
             https://inbox.sourceware.org/gdb-patches/875x8i970d.fsf@tromey.com/

  Patch 4/6: (unchanged from V5, no review comments)
             https://inbox.sourceware.org/gdb-patches/20260129095918.2216661-5-klaus.gerlicher@intel.com/

  Patch 5/6: Reviewed-By: Eli Zaretskii <eliz@gnu.org> (documentation parts)
             https://inbox.sourceware.org/gdb-patches/86ttb4t6kz.fsf@gnu.org/
             Changes: documentation improvements, formatting fixes

  Patch 6/6: Reviewed-By: Eli Zaretskii <eliz@gnu.org> (documentation parts)
             https://inbox.sourceware.org/gdb-patches/86ldx8t6ex.fsf@gnu.org/
             Changes: documentation improvements, formatting fixes

  Overall series: Reviewed-By: Guinevere Larsen <guinevere@redhat.com>
                  https://inbox.sourceware.org/gdb-patches/bc6fd851-29c1-436e-a833-a53c0cf5a18d@redhat.com/

Thanks to all reviewers for their thorough feedback throughout the
v3, v4, and v5 iterations.

Best regards,
Klaus

Natalia Saiapova (6):
  gdb: use schedlock_applies in user_visible_resume_ptid.
  gdb, cli: remove left-over code from "set_logging_on".
  gdb, cli: pass the argument of a set command to its callback.
  gdb: change the internal representation of scheduler locking.
  gdb: refine commands to control scheduler locking.
  gdb: add eval option to lock the scheduler during infcalls.

 gdb/NEWS                                      |  26 ++
 gdb/cli/cli-logging.c                         |   5 -
 gdb/cli/cli-setshow.c                         |   2 +-
 gdb/doc/gdb.texinfo                           |  77 +++-
 gdb/infrun.c                                  | 414 +++++++++++++++---
 .../gdb.mi/user-selected-context-sync.exp     |  23 +-
 .../gdb.threads/hand-call-in-threads.exp      |  12 +-
 .../multiple-successive-infcall.exp           |   7 +-
 gdb/testsuite/gdb.threads/schedlock.exp       | 105 ++++-
 gdb/testsuite/lib/gdb.exp                     |  71 ++-
 10 files changed, 621 insertions(+), 121 deletions(-)

-- 
2.34.1


[-- Attachment #2.1: Type: text/plain, Size: 329 bytes --]

Intel Deutschland GmbH
Registered Address: Dornacher Straße 1, 85622 Feldkirchen, Germany
Tel: +49 89 991 430, www.intel.de
Managing Directors: Harry Demas, Jeffrey Schneiderman, Yin Chong Sorrell
Chairperson of the Supervisory Board: Nicole Lau
Registered Seat: Munich
Commercial Register: Amtsgericht München HRB 186928

[-- Attachment #2.2: Type: text/html, Size: 357 bytes --]