Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Klaus Gerlicher <klaus.gerlicher@intel.com>
To: gdb-patches@sourceware.org
Subject: [PATCH v6 3/6] gdb, cli: pass the argument of a set command to its callback.
Date: Wed,  4 Feb 2026 13:37:50 +0000	[thread overview]
Message-ID: <20260204133753.547281-4-klaus.gerlicher@intel.com> (raw)
In-Reply-To: <20260204133753.547281-1-klaus.gerlicher@intel.com>

[-- Attachment #1: Type: text/plain, Size: 1213 bytes --]

From: Natalia Saiapova <natalia.saiapova@intel.com>

This might be useful, if some commands need to have a special case if
run w/o arguments.

I am going to use it in
  gdb: refine commands to control scheduler locking.
to keep the old behaviour of the
  set scheduler-locking step
which should set both
  set scheduler-locking step on
  set scheduler-locking replay step on
To do this, the set-command needs to detect that it was issued without
arguments and have a special handling for this.

Without the special handling, the command
  set scheduler-locking step
would set only
  set scheduler-locking step on

Approved-By: Tom Tromey <tom@tromey.com>
---
 gdb/cli/cli-setshow.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gdb/cli/cli-setshow.c b/gdb/cli/cli-setshow.c
index 7688da015de..f1f313a4cd0 100644
--- a/gdb/cli/cli-setshow.c
+++ b/gdb/cli/cli-setshow.c
@@ -455,7 +455,7 @@ do_set_command (const char *arg, int from_tty, struct cmd_list_element *c)
       error (_("gdb internal error: bad var_type in do_setshow_command"));
     }
 
-  c->func (NULL, from_tty, c);
+  c->func (arg, from_tty, c);
 
   if (notify_command_param_changed_p (option_changed, c))
     {
-- 
2.34.1


[-- Attachment #2.1: Type: text/plain, Size: 329 bytes --]

Intel Deutschland GmbH
Registered Address: Dornacher Straße 1, 85622 Feldkirchen, Germany
Tel: +49 89 991 430, www.intel.de
Managing Directors: Harry Demas, Jeffrey Schneiderman, Yin Chong Sorrell
Chairperson of the Supervisory Board: Nicole Lau
Registered Seat: Munich
Commercial Register: Amtsgericht München HRB 186928

[-- Attachment #2.2: Type: text/html, Size: 387 bytes --]

  parent reply	other threads:[~2026-02-04 13:40 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-04 13:37 [PATCH v6 0/6] gdb: refine scheduler locking settings Klaus Gerlicher
2026-02-04 13:37 ` [PATCH v6 1/6] gdb: use schedlock_applies in user_visible_resume_ptid Klaus Gerlicher
2026-02-04 13:37 ` [PATCH v6 2/6] gdb, cli: remove left-over code from "set_logging_on" Klaus Gerlicher
2026-02-04 14:13   ` Gerlicher, Klaus
2026-02-04 13:37 ` Klaus Gerlicher [this message]
2026-02-04 13:37 ` [PATCH v6 4/6] gdb: change the internal representation of scheduler locking Klaus Gerlicher
2026-02-04 13:37 ` [PATCH v6 5/6] gdb: refine commands to control " Klaus Gerlicher
2026-02-04 14:25   ` Eli Zaretskii
2026-02-04 13:37 ` [PATCH v6 6/6] gdb: add eval option to lock the scheduler during infcalls Klaus Gerlicher
2026-02-04 14:22   ` Eli Zaretskii
2026-02-17  9:03 ` [PATCH v6 0/6] gdb: refine scheduler locking settings Gerlicher, Klaus
2026-03-03  8:15   ` Gerlicher, Klaus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260204133753.547281-4-klaus.gerlicher@intel.com \
    --to=klaus.gerlicher@intel.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox