RE: [PATCH v6 2/6] gdb, cli: remove left-over code from "set_logging_on".

["Gerlicher, Klaus" <klaus.gerlicher@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 1998 bytes --]

I think the approved by was accidentally added in this patch. Please ignore.

Sorry
Klaus

> -----Original Message-----
> From: Klaus Gerlicher <klaus.gerlicher@intel.com>
> Sent: Wednesday, February 4, 2026 2:38 PM
> To: gdb-patches@sourceware.org
> Subject: [PATCH v6 2/6] gdb, cli: remove left-over code from
> "set_logging_on".
> 
> From: Natalia Saiapova <natalia.saiapova@intel.com>
> 
> This is a refactoring.  Remove the left-over code, which rewrites
> the logging filename in "set logging on" command.
> 
> The code became unused after the deprecation of "set logging (on|off)"
> command.  Before the deprecation, the command could also take a file
> name and rewrite the logging file, e.g.:
>   (gdb) set logging on lalala
>   Copying output to lalala.
>   Copying debug output to lalala.
> 
> After the command was deprecated and reimplemented as an alias to "set
> logging enable on", additional input after "on" became invalid:
> 
>   (gdb) set logging on lalala
>   Warning: 'set logging on', an alias for the command 'set logging enabled', is
> deprecated.
>   Use 'set logging enabled on'.
> 
>   "on" or "off" expected.
>   (gdb) set logging on lalala
>   "on" or "off" expected.
>   (gdb) set logging enable on lalala
>   "on" or "off" expected.
>   (gdb) set logging enable on
>   Copying output to gdb.txt.
>   Copying debug output to gdb.txt.
> 
> Approved-By: Tom Tromey <tom@tromey.com>
> ---
>  gdb/cli/cli-logging.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/gdb/cli/cli-logging.c b/gdb/cli/cli-logging.c
> index c00c6bf0488..2ba96e55dc3 100644
> --- a/gdb/cli/cli-logging.c
> +++ b/gdb/cli/cli-logging.c
> @@ -159,11 +159,6 @@ handle_redirections (int from_tty)
>  static void
>  set_logging_on (const char *args, int from_tty)
>  {
> -  const char *rest = args;
> -
> -  if (rest && *rest)
> -    logging_filename = rest;
> -
>    handle_redirections (from_tty);
>  }
> 
> --
> 2.34.1


[-- Attachment #2.1: Type: text/plain, Size: 329 bytes --]

Intel Deutschland GmbH
Registered Address: Dornacher Straße 1, 85622 Feldkirchen, Germany
Tel: +49 89 991 430, www.intel.de
Managing Directors: Harry Demas, Jeffrey Schneiderman, Yin Chong Sorrell
Chairperson of the Supervisory Board: Nicole Lau
Registered Seat: Munich
Commercial Register: Amtsgericht München HRB 186928

[-- Attachment #2.2: Type: text/html, Size: 387 bytes --]