Re: [commit] [PATCH] cd command defaults to ~

[Nathaniel Flath <flat0103@gmail.com>]

Sorry - I saw your later email about the regression - do I need to fix
this commit or did you fix/apply it?

Thanks,
Nathaniel Flath

On Mon, Aug 6, 2012 at 10:14 AM, Jan Kratochvil
<jan.kratochvil@redhat.com> wrote:
> On Mon, 06 Aug 2012 11:14:57 +0200, Nathaniel Flath wrote:
>> gdb/
>> 2012-07-21  Nathaniel Flath  <flat0103@gmail.com>
>>
>>         * NEWS: New entry for 'cd' default parameters.
>>         * cli/cli-cmds.c (cd_command): Replace error_no_arg by DIR assignment.
>>
>> doc/
> gdb/doc/
>> 2012-07-21  Nathaniel Flath  <flat0103@gmail.com>
>>
>>         * gdb.texinfo (Working Directory): Added information about new
>>           default argument for 'cd' command.
>           ^^
> Here the indentation should be two spaces left, ignoring '* ' above.
>
> The NEWS entry was against too old tree, adjusted its position (to be post-7.5).
>
>
> Thanks,
> Jan
>
>
> http://sourceware.org/ml/gdb-cvs/2012-08/msg00048.html
>
> --- src/gdb/ChangeLog   2012/08/03 20:52:46     1.14559
> +++ src/gdb/ChangeLog   2012/08/06 17:13:23     1.14560
> @@ -1,3 +1,8 @@
> +2012-08-06  Nathaniel Flath  <flat0103@gmail.com>
> +
> +       * NEWS: New entry for 'cd' default parameters.
> +       * cli/cli-cmds.c (cd_command): Replace error_no_arg by DIR assignment.
> +
>  2012-08-03  Tom Tromey  <tromey@redhat.com>
>
>         * dwarf2-frame.c (dwarf2_frame_cache): Call do_cleanups before
> --- src/gdb/NEWS        2012/07/26 15:28:21     1.537
> +++ src/gdb/NEWS        2012/08/06 17:13:26     1.538
> @@ -3,6 +3,9 @@
>
>  *** Changes since GDB 7.5
>
> +* The 'cd' command now defaults to using '~' (the home directory) if not
> +  given an argument.
> +
>  * New configure options
>
>  --enable-libmcheck/--disable-libmcheck
> --- src/gdb/cli/cli-cmds.c      2012/07/26 16:57:22     1.132
> +++ src/gdb/cli/cli-cmds.c      2012/08/06 17:13:26     1.133
> @@ -365,7 +365,7 @@
>    dont_repeat ();
>
>    if (dir == 0)
> -    error_no_arg (_("new working directory"));
> +    dir = "~";
>
>    dir = tilde_expand (dir);
>    make_cleanup (xfree, dir);
> --- src/gdb/doc/ChangeLog       2012/08/06 14:28:45     1.1352
> +++ src/gdb/doc/ChangeLog       2012/08/06 17:13:27     1.1353
> @@ -1,3 +1,8 @@
> +2012-08-06  Nathaniel Flath  <flat0103@gmail.com>
> +
> +       * gdb.texinfo (Working Directory): Added information about new
> +       default argument for 'cd' command.
> +
>  2012-08-06  Yao Qi  <yao@codesourcery.com>
>
>         * gdb.texinfo (Remote Configuration): Add kindex for 'set
> --- src/gdb/doc/gdb.texinfo     2012/08/06 14:28:45     1.996
> +++ src/gdb/doc/gdb.texinfo     2012/08/06 17:13:27     1.997
> @@ -2267,8 +2267,9 @@
>  @table @code
>  @kindex cd
>  @cindex change working directory
> -@item cd @var{directory}
> -Set the @value{GDBN} working directory to @var{directory}.
> +@item cd @r{[}@var{directory}@r{]}
> +Set the @value{GDBN} working directory to @var{directory}.  If not
> +given, @var{directory} uses @file{'~'}.
>
>  @kindex pwd
>  @item pwd