From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Nathaniel Flath <flat0103@gmail.com>
Cc: Eli Zaretskii <eliz@gnu.org>,
tromey@redhat.com, gdb-patches@sourceware.org
Subject: [obv] testsuite: default.exp: Fix cd regression [Re: [commit] [PATCH] cd command defaults to ~]
Date: Tue, 07 Aug 2012 05:52:00 -0000 [thread overview]
Message-ID: <20120807055134.GA32255@host2.jankratochvil.net> (raw)
In-Reply-To: <20120806171437.GA10148@host2.jankratochvil.net>
On Mon, 06 Aug 2012 19:14:37 +0200, Jan Kratochvil wrote:
> On Mon, 06 Aug 2012 11:14:57 +0200, Nathaniel Flath wrote:
> > gdb/
> > 2012-07-21 Nathaniel Flath <flat0103@gmail.com>
> >
> > * NEWS: New entry for 'cd' default parameters.
> > * cli/cli-cmds.c (cd_command): Replace error_no_arg by DIR assignment.
It has caused:
cd
-Argument required (new working directory).
-(gdb) PASS: gdb.base/default.exp: cd
+Working directory /home/jkratoch.
+(gdb) FAIL: gdb.base/default.exp: cd
One should run a regression testsuite, I forgot you did not.
Checked in.
Jan
http://sourceware.org/ml/gdb-cvs/2012-08/msg00059.html
--- src/gdb/testsuite/ChangeLog 2012/08/06 20:14:10 1.3326
+++ src/gdb/testsuite/ChangeLog 2012/08/07 05:49:01 1.3327
@@ -1,3 +1,7 @@
+2012-08-07 Jan Kratochvil <jan.kratochvil@redhat.com>
+
+ * gdb.base/default.exp (cd): Accept new directory with no arguments.
+
2012-08-06 Jan Kratochvil <jan.kratochvil@redhat.com>
* gdb.base/list.exp (test_only_end): New function.
--- src/gdb/testsuite/gdb.base/default.exp 2012/04/27 20:52:06 1.59
+++ src/gdb/testsuite/gdb.base/default.exp 2012/08/07 05:49:02 1.60
@@ -84,7 +84,7 @@
gdb_test "catch" "Catch requires an event name..*" "catch"
#test cd
-gdb_test "cd" "Argument required .new working directory.*" "cd"
+gdb_test "cd" "Working directory \[^\r\n\]*\\."
#test clear
gdb_test "clear" "No source file specified..*" "clear"
next prev parent reply other threads:[~2012-08-07 5:52 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-05 2:31 [PATCH] cd command defaults to ~ Nathaniel Flath
2012-07-05 14:00 ` Jan Kratochvil
2012-07-05 17:34 ` Nathaniel Flath
2012-07-05 17:50 ` Eli Zaretskii
2012-07-05 18:09 ` Tom Tromey
2012-07-07 4:29 ` Nathaniel Flath
2012-07-07 6:17 ` Jan Kratochvil
[not found] ` <CAPrg3HBCBs5tmuM9qH=Q=_PgPVb8Rb-=fbPX_ZSy1dEWgKcY9g@mail.gmail.com>
[not found] ` <20120722163408.GA20790@host2.jankratochvil.net>
2012-07-22 16:37 ` Nathaniel Flath
2012-07-22 16:50 ` Jan Kratochvil
2012-07-23 7:42 ` Sergio Durigan Junior
2012-07-23 14:14 ` Tom Tromey
2012-08-04 5:55 ` Nathaniel Flath
2012-08-04 6:05 ` Sergio Durigan Junior
2012-08-04 7:11 ` Eli Zaretskii
2012-08-04 17:10 ` Nathaniel Flath
2012-08-04 17:16 ` Eli Zaretskii
2012-08-04 18:16 ` Nathaniel Flath
2012-08-04 18:28 ` Jan Kratochvil
[not found] ` <CAPrg3HDpFytQmCHe2GSzW=_ckAcNXN5UPJ5qPWDPHgwzY8RWzw@mail.gmail.com>
2012-08-06 9:15 ` Nathaniel Flath
2012-08-06 18:43 ` [commit] " Jan Kratochvil
2012-08-07 5:52 ` Jan Kratochvil [this message]
2012-08-07 7:31 ` Nathaniel Flath
2012-08-07 7:53 ` Jan Kratochvil
2012-08-07 16:02 ` Nathaniel Flath
2012-07-22 17:13 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120807055134.GA32255@host2.jankratochvil.net \
--to=jan.kratochvil@redhat.com \
--cc=eliz@gnu.org \
--cc=flat0103@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox