From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Nathaniel Flath <flat0103@gmail.com>
Cc: Tom Tromey <tromey@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] cd command defaults to ~
Date: Sun, 22 Jul 2012 16:50:00 -0000 [thread overview]
Message-ID: <20120722164948.GA20982@host2.jankratochvil.net> (raw)
In-Reply-To: <CAPrg3HA+mpqmBOLkhShuCm_HK0dRqfrZ=vTpfMG3cq2R_ANFNA@mail.gmail.com>
On Sun, 22 Jul 2012 18:37:04 +0200, Nathaniel Flath wrote:
> Whoops, missed this email for a bit.
> +2012-07-21 Nathaniel Flath <flat0103@gmail.com>
> + * cli-cmds.c (cd_command) changed default argument to '~'.
This is not a real ChangeLog, see other entries plus:
http://www.gnu.org/prep/standards/standards.html#Change-Logs
BTW it is better not to modify the ChangeLog file(s) itself but write is as
a text along the patch, the repository ChangeLog file(s) as constantly
changing.
Your ChangeLog should have been, including the spacing:
gdb/
2012-07-21 Nathaniel Flath <flat0103@gmail.com>
* NEWS: New entry for 'cd' default parameters.
* cli/cli-cmds.c (cd_command): Replace error_no_arg by DIR assignment.
doc/
2012-07-21 Nathaniel Flath <flat0103@gmail.com>
* gdb.texinfo (Working Directory): <FIXME>
But the doc patch part does not seem to be right to me (although authoritative
is Eli). I would probably create a new entry besides 'cd DIRECTORY' and 'pwd'
also 'cd' (without DIRECTORY). Or one can modify 'cd DIRECTORY'
to be 'cd [DIRECTORY]' instead.
I guess Tom assumes no FSF copyright assignment is needed for this patch, Tom?
Thanks,
Jan
next prev parent reply other threads:[~2012-07-22 16:50 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-05 2:31 Nathaniel Flath
2012-07-05 14:00 ` Jan Kratochvil
2012-07-05 17:34 ` Nathaniel Flath
2012-07-05 17:50 ` Eli Zaretskii
2012-07-05 18:09 ` Tom Tromey
2012-07-07 4:29 ` Nathaniel Flath
2012-07-07 6:17 ` Jan Kratochvil
[not found] ` <CAPrg3HBCBs5tmuM9qH=Q=_PgPVb8Rb-=fbPX_ZSy1dEWgKcY9g@mail.gmail.com>
[not found] ` <20120722163408.GA20790@host2.jankratochvil.net>
2012-07-22 16:37 ` Nathaniel Flath
2012-07-22 16:50 ` Jan Kratochvil [this message]
2012-07-23 7:42 ` Sergio Durigan Junior
2012-07-23 14:14 ` Tom Tromey
2012-08-04 5:55 ` Nathaniel Flath
2012-08-04 6:05 ` Sergio Durigan Junior
2012-08-04 7:11 ` Eli Zaretskii
2012-08-04 17:10 ` Nathaniel Flath
2012-08-04 17:16 ` Eli Zaretskii
2012-08-04 18:16 ` Nathaniel Flath
2012-08-04 18:28 ` Jan Kratochvil
[not found] ` <CAPrg3HDpFytQmCHe2GSzW=_ckAcNXN5UPJ5qPWDPHgwzY8RWzw@mail.gmail.com>
2012-08-06 9:15 ` Nathaniel Flath
2012-08-06 18:43 ` [commit] " Jan Kratochvil
2012-08-07 5:52 ` [obv] testsuite: default.exp: Fix cd regression [Re: [commit] [PATCH] cd command defaults to ~] Jan Kratochvil
2012-08-07 7:31 ` [commit] [PATCH] cd command defaults to ~ Nathaniel Flath
2012-08-07 7:53 ` Jan Kratochvil
2012-08-07 16:02 ` Nathaniel Flath
2012-07-22 17:13 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120722164948.GA20982@host2.jankratochvil.net \
--to=jan.kratochvil@redhat.com \
--cc=flat0103@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox