From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17730 invoked by alias); 22 Jul 2012 16:50:16 -0000 Received: (qmail 17716 invoked by uid 22791); 22 Jul 2012 16:50:15 -0000 X-SWARE-Spam-Status: No, hits=-6.3 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 22 Jul 2012 16:49:58 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q6MGnvFY024068 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sun, 22 Jul 2012 12:49:57 -0400 Received: from host2.jankratochvil.net (ovpn-116-30.ams2.redhat.com [10.36.116.30]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q6MGnred028604 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Sun, 22 Jul 2012 12:49:56 -0400 Date: Sun, 22 Jul 2012 16:50:00 -0000 From: Jan Kratochvil To: Nathaniel Flath Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH] cd command defaults to ~ Message-ID: <20120722164948.GA20982@host2.jankratochvil.net> References: <20120705140038.GB27886@host2.jankratochvil.net> <87d34arsf3.fsf@fleche.redhat.com> <20120707061655.GA28438@host2.jankratochvil.net> <20120722163408.GA20790@host2.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-07/txt/msg00430.txt.bz2 On Sun, 22 Jul 2012 18:37:04 +0200, Nathaniel Flath wrote: > Whoops, missed this email for a bit. > +2012-07-21 Nathaniel Flath > + * cli-cmds.c (cd_command) changed default argument to '~'. This is not a real ChangeLog, see other entries plus: http://www.gnu.org/prep/standards/standards.html#Change-Logs BTW it is better not to modify the ChangeLog file(s) itself but write is as a text along the patch, the repository ChangeLog file(s) as constantly changing. Your ChangeLog should have been, including the spacing: gdb/ 2012-07-21 Nathaniel Flath * NEWS: New entry for 'cd' default parameters. * cli/cli-cmds.c (cd_command): Replace error_no_arg by DIR assignment. doc/ 2012-07-21 Nathaniel Flath * gdb.texinfo (Working Directory): But the doc patch part does not seem to be right to me (although authoritative is Eli). I would probably create a new entry besides 'cd DIRECTORY' and 'pwd' also 'cd' (without DIRECTORY). Or one can modify 'cd DIRECTORY' to be 'cd [DIRECTORY]' instead. I guess Tom assumes no FSF copyright assignment is needed for this patch, Tom? Thanks, Jan