From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26551 invoked by alias); 7 Aug 2012 05:52:02 -0000 Received: (qmail 26523 invoked by uid 22791); 7 Aug 2012 05:52:01 -0000 X-SWARE-Spam-Status: No, hits=-6.3 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 07 Aug 2012 05:51:43 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q775pd6v027114 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 7 Aug 2012 01:51:39 -0400 Received: from host2.jankratochvil.net (ovpn-116-27.ams2.redhat.com [10.36.116.27]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q775pZY1004012 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Tue, 7 Aug 2012 01:51:37 -0400 Date: Tue, 07 Aug 2012 05:52:00 -0000 From: Jan Kratochvil To: Nathaniel Flath Cc: Eli Zaretskii , tromey@redhat.com, gdb-patches@sourceware.org Subject: [obv] testsuite: default.exp: Fix cd regression [Re: [commit] [PATCH] cd command defaults to ~] Message-ID: <20120807055134.GA32255@host2.jankratochvil.net> References: <87sjcisgyj.fsf@fleche.redhat.com> <83d337b0a0.fsf@gnu.org> <83628ybmsl.fsf@gnu.org> <20120804182756.GA25594@host2.jankratochvil.net> <20120806171437.GA10148@host2.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120806171437.GA10148@host2.jankratochvil.net> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-08/txt/msg00208.txt.bz2 On Mon, 06 Aug 2012 19:14:37 +0200, Jan Kratochvil wrote: > On Mon, 06 Aug 2012 11:14:57 +0200, Nathaniel Flath wrote: > > gdb/ > > 2012-07-21 Nathaniel Flath > > > > * NEWS: New entry for 'cd' default parameters. > > * cli/cli-cmds.c (cd_command): Replace error_no_arg by DIR assignment. It has caused: cd -Argument required (new working directory). -(gdb) PASS: gdb.base/default.exp: cd +Working directory /home/jkratoch. +(gdb) FAIL: gdb.base/default.exp: cd One should run a regression testsuite, I forgot you did not. Checked in. Jan http://sourceware.org/ml/gdb-cvs/2012-08/msg00059.html --- src/gdb/testsuite/ChangeLog 2012/08/06 20:14:10 1.3326 +++ src/gdb/testsuite/ChangeLog 2012/08/07 05:49:01 1.3327 @@ -1,3 +1,7 @@ +2012-08-07 Jan Kratochvil + + * gdb.base/default.exp (cd): Accept new directory with no arguments. + 2012-08-06 Jan Kratochvil * gdb.base/list.exp (test_only_end): New function. --- src/gdb/testsuite/gdb.base/default.exp 2012/04/27 20:52:06 1.59 +++ src/gdb/testsuite/gdb.base/default.exp 2012/08/07 05:49:02 1.60 @@ -84,7 +84,7 @@ gdb_test "catch" "Catch requires an event name..*" "catch" #test cd -gdb_test "cd" "Argument required .new working directory.*" "cd" +gdb_test "cd" "Working directory \[^\r\n\]*\\." #test clear gdb_test "clear" "No source file specified..*" "clear"