From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7055 invoked by alias); 7 Aug 2012 07:31:02 -0000 Received: (qmail 7041 invoked by uid 22791); 7 Aug 2012 07:31:00 -0000 X-SWARE-Spam-Status: No, hits=-5.7 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,TW_BM X-Spam-Check-By: sourceware.org Received: from mail-wg0-f43.google.com (HELO mail-wg0-f43.google.com) (74.125.82.43) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 07 Aug 2012 07:30:46 +0000 Received: by wgbdr1 with SMTP id dr1so2847680wgb.12 for ; Tue, 07 Aug 2012 00:30:44 -0700 (PDT) MIME-Version: 1.0 Received: by 10.180.14.9 with SMTP id l9mr1658588wic.21.1344324644709; Tue, 07 Aug 2012 00:30:44 -0700 (PDT) Received: by 10.216.238.13 with HTTP; Tue, 7 Aug 2012 00:30:44 -0700 (PDT) In-Reply-To: <20120806171437.GA10148@host2.jankratochvil.net> References: <20120722164948.GA20982@host2.jankratochvil.net> <87sjcisgyj.fsf@fleche.redhat.com> <83d337b0a0.fsf@gnu.org> <83628ybmsl.fsf@gnu.org> <20120804182756.GA25594@host2.jankratochvil.net> <20120806171437.GA10148@host2.jankratochvil.net> Date: Tue, 07 Aug 2012 07:31:00 -0000 Message-ID: Subject: Re: [commit] [PATCH] cd command defaults to ~ From: Nathaniel Flath To: Jan Kratochvil Cc: Eli Zaretskii , tromey@redhat.com, gdb-patches@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-08/txt/msg00221.txt.bz2 Sorry - I saw your later email about the regression - do I need to fix this commit or did you fix/apply it? Thanks, Nathaniel Flath On Mon, Aug 6, 2012 at 10:14 AM, Jan Kratochvil wrote: > On Mon, 06 Aug 2012 11:14:57 +0200, Nathaniel Flath wrote: >> gdb/ >> 2012-07-21 Nathaniel Flath >> >> * NEWS: New entry for 'cd' default parameters. >> * cli/cli-cmds.c (cd_command): Replace error_no_arg by DIR assignment. >> >> doc/ > gdb/doc/ >> 2012-07-21 Nathaniel Flath >> >> * gdb.texinfo (Working Directory): Added information about new >> default argument for 'cd' command. > ^^ > Here the indentation should be two spaces left, ignoring '* ' above. > > The NEWS entry was against too old tree, adjusted its position (to be post-7.5). > > > Thanks, > Jan > > > http://sourceware.org/ml/gdb-cvs/2012-08/msg00048.html > > --- src/gdb/ChangeLog 2012/08/03 20:52:46 1.14559 > +++ src/gdb/ChangeLog 2012/08/06 17:13:23 1.14560 > @@ -1,3 +1,8 @@ > +2012-08-06 Nathaniel Flath > + > + * NEWS: New entry for 'cd' default parameters. > + * cli/cli-cmds.c (cd_command): Replace error_no_arg by DIR assignment. > + > 2012-08-03 Tom Tromey > > * dwarf2-frame.c (dwarf2_frame_cache): Call do_cleanups before > --- src/gdb/NEWS 2012/07/26 15:28:21 1.537 > +++ src/gdb/NEWS 2012/08/06 17:13:26 1.538 > @@ -3,6 +3,9 @@ > > *** Changes since GDB 7.5 > > +* The 'cd' command now defaults to using '~' (the home directory) if not > + given an argument. > + > * New configure options > > --enable-libmcheck/--disable-libmcheck > --- src/gdb/cli/cli-cmds.c 2012/07/26 16:57:22 1.132 > +++ src/gdb/cli/cli-cmds.c 2012/08/06 17:13:26 1.133 > @@ -365,7 +365,7 @@ > dont_repeat (); > > if (dir == 0) > - error_no_arg (_("new working directory")); > + dir = "~"; > > dir = tilde_expand (dir); > make_cleanup (xfree, dir); > --- src/gdb/doc/ChangeLog 2012/08/06 14:28:45 1.1352 > +++ src/gdb/doc/ChangeLog 2012/08/06 17:13:27 1.1353 > @@ -1,3 +1,8 @@ > +2012-08-06 Nathaniel Flath > + > + * gdb.texinfo (Working Directory): Added information about new > + default argument for 'cd' command. > + > 2012-08-06 Yao Qi > > * gdb.texinfo (Remote Configuration): Add kindex for 'set > --- src/gdb/doc/gdb.texinfo 2012/08/06 14:28:45 1.996 > +++ src/gdb/doc/gdb.texinfo 2012/08/06 17:13:27 1.997 > @@ -2267,8 +2267,9 @@ > @table @code > @kindex cd > @cindex change working directory > -@item cd @var{directory} > -Set the @value{GDBN} working directory to @var{directory}. > +@item cd @r{[}@var{directory}@r{]} > +Set the @value{GDBN} working directory to @var{directory}. If not > +given, @var{directory} uses @file{'~'}. > > @kindex pwd > @item pwd