From: "Christian Biesinger via gdb-patches" <gdb-patches@sourceware.org>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH 2/8] Dont' allow copying of auto_obstack
Date: Sun, 09 Feb 2020 23:56:00 -0000 [thread overview]
Message-ID: <CAPTJ0XGxPVg3siN-Rhf2zCQ2d_mK-ZyGONhBaG7Q6k2nTbp7Yg@mail.gmail.com> (raw)
In-Reply-To: <20200208152758.29385-3-tom@tromey.com>
On Sat, Feb 8, 2020, 10:28 Tom Tromey <tom@tromey.com> wrote:
> Add DISABLE_COPY_AND_ASSIGN to struct auto_obstack, to prevent copying
> it. Copying an auto_obstack would be a bug.
>
Typo in the subject/first line (Dont' -> Don't)
> gdb/ChangeLog
> 2020-02-08 Tom Tromey <tom@tromey.com>
>
> * gdb_obstack.h (struct auto_obstack): Use
> DISABLE_COPY_AND_ASSIGN.
>
> Change-Id: Ic9e5ab20acfcfa61c241fed4d99bbb1caefba3cd
> ---
> gdb/ChangeLog | 5 +++++
> gdb/gdb_obstack.h | 2 ++
> 2 files changed, 7 insertions(+)
>
> diff --git a/gdb/gdb_obstack.h b/gdb/gdb_obstack.h
> index fb9295f5020..9b1d907678f 100644
> --- a/gdb/gdb_obstack.h
> +++ b/gdb/gdb_obstack.h
> @@ -125,6 +125,8 @@ struct auto_obstack : obstack
> ~auto_obstack ()
> { obstack_free (this, NULL); }
>
> + DISABLE_COPY_AND_ASSIGN (auto_obstack);
> +
> /* Free all memory in the obstack but leave it valid for further
> allocation. */
> void clear ()
> --
> 2.17.2
>
>
next prev parent reply other threads:[~2020-02-09 23:56 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-08 15:28 [PATCH 0/8] Share DWARF frame information across inferiors Tom Tromey
2020-02-08 15:28 ` [PATCH 5/8] Add per-unit obstack Tom Tromey
2020-02-11 10:34 ` Luis Machado
2020-02-12 3:53 ` Simon Marchi
2020-02-12 22:41 ` Tom Tromey
2020-02-12 22:48 ` Simon Marchi
2020-02-12 22:51 ` Tom Tromey
2020-02-08 15:28 ` [PATCH 2/8] Dont' allow copying of auto_obstack Tom Tromey
2020-02-09 23:56 ` Christian Biesinger via gdb-patches [this message]
2020-02-12 0:16 ` Tom Tromey
2020-02-12 0:53 ` Simon Marchi
2020-02-12 1:01 ` Tom Tromey
2020-02-08 15:28 ` [PATCH 1/8] Don't forward-declare struct objfile in frame.h Tom Tromey
2020-02-12 0:51 ` Simon Marchi
2020-02-12 1:59 ` Tom Tromey
2020-02-08 15:28 ` [PATCH 6/8] Remove a use of the comp_unit backlink Tom Tromey
2020-02-08 15:28 ` [PATCH 7/8] Remove the objfile backlink from comp_unit Tom Tromey
2020-02-09 23:56 ` Christian Biesinger via gdb-patches
2020-02-12 0:26 ` Tom Tromey
2020-02-11 10:40 ` Luis Machado
2020-02-08 15:28 ` [PATCH 8/8] Move the frame data to the BFD when possible Tom Tromey
2020-02-11 10:45 ` Luis Machado
2020-02-12 0:31 ` Tom Tromey
2020-11-14 3:31 ` Simon Marchi
2020-02-08 15:28 ` [PATCH 3/8] Change fde table to a vector Tom Tromey
[not found] ` <5a373a74-9283-5d82-a22d-7a2606a4d3f5@linaro.org>
2020-02-12 0:29 ` Tom Tromey
2020-02-12 3:28 ` Simon Marchi
2020-02-12 3:33 ` Simon Marchi
2020-02-12 22:36 ` Tom Tromey
2020-02-12 22:47 ` Simon Marchi
2020-02-08 15:28 ` [PATCH 4/8] Store the comp_unit instead of the FDE table Tom Tromey
2020-02-09 23:56 ` Christian Biesinger via gdb-patches
2020-02-12 0:19 ` Tom Tromey
2020-02-11 10:32 ` Luis Machado
2020-02-12 0:20 ` Tom Tromey
2020-02-12 3:36 ` Simon Marchi
2020-02-12 22:20 ` Tom Tromey
2020-02-08 15:29 ` [PATCH 0/8] Share DWARF frame information across inferiors Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPTJ0XGxPVg3siN-Rhf2zCQ2d_mK-ZyGONhBaG7Q6k2nTbp7Yg@mail.gmail.com \
--to=gdb-patches@sourceware.org \
--cc=cbiesinger@google.com \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox