From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 72846 invoked by alias); 9 Feb 2020 23:56:06 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 72836 invoked by uid 89); 9 Feb 2020 23:56:05 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-29.4 required=5.0 tests=AWL,BAYES_00,ENV_AND_HDR_SPF_MATCH,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPF_PASS,USER_IN_DEF_SPF_WL autolearn=ham version=3.3.1 spammy=HX-Gm-Message-State:APjAAAV, H*c:alternative, HX-Spam-Relays-External:209.85.167.194, H*RU:209.85.167.194 X-HELO: mail-oi1-f194.google.com Received: from mail-oi1-f194.google.com (HELO mail-oi1-f194.google.com) (209.85.167.194) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 09 Feb 2020 23:56:04 +0000 Received: by mail-oi1-f194.google.com with SMTP id c16so7613129oic.3 for ; Sun, 09 Feb 2020 15:56:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=8k2ZYKyBJ3sfC4TRMaJ81fRcqBgOcynYPKtLWRQic1Q=; b=VWeEwdWlmFuA4oIspmn0YniwM0LfaycQDd3KFjz4HidbEcFDE/R1VuFX48J2bBxk+6 KsKP7YJtUuZ+41HgVpZrNglLIeJ3Bo2VDTxOL1/UVD6mPWvVk76yOWWvoVmCWqmB/cSJ 6qfWYFAxbw6AlGmZ0COqlSNU4PUE7cWm6jqeo1n18UG2pyJt1D/RbRAHOnZ2CSV8jjIn I7XnvGWRkVgZfBUuUP2ts910f2NW/jKpQRWo6nHpkTF5P/aEmN+P+1anj3zwMOfOsCg7 uVDmTg0vY1KSFuTeFQ5GlgFeb4nLnTgStk/IrAFB87+t/4VjDxojcgJkZEs+MS1yK0jU TjJQ== MIME-Version: 1.0 References: <20200208152758.29385-1-tom@tromey.com> <20200208152758.29385-3-tom@tromey.com> In-Reply-To: <20200208152758.29385-3-tom@tromey.com> From: "Christian Biesinger via gdb-patches" Reply-To: Christian Biesinger Date: Sun, 09 Feb 2020 23:56:00 -0000 Message-ID: Subject: Re: [PATCH 2/8] Dont' allow copying of auto_obstack To: Tom Tromey Cc: gdb-patches Content-Type: text/plain; charset="UTF-8" X-IsSubscribed: yes X-SW-Source: 2020-02/txt/msg00264.txt.bz2 On Sat, Feb 8, 2020, 10:28 Tom Tromey wrote: > Add DISABLE_COPY_AND_ASSIGN to struct auto_obstack, to prevent copying > it. Copying an auto_obstack would be a bug. > Typo in the subject/first line (Dont' -> Don't) > gdb/ChangeLog > 2020-02-08 Tom Tromey > > * gdb_obstack.h (struct auto_obstack): Use > DISABLE_COPY_AND_ASSIGN. > > Change-Id: Ic9e5ab20acfcfa61c241fed4d99bbb1caefba3cd > --- > gdb/ChangeLog | 5 +++++ > gdb/gdb_obstack.h | 2 ++ > 2 files changed, 7 insertions(+) > > diff --git a/gdb/gdb_obstack.h b/gdb/gdb_obstack.h > index fb9295f5020..9b1d907678f 100644 > --- a/gdb/gdb_obstack.h > +++ b/gdb/gdb_obstack.h > @@ -125,6 +125,8 @@ struct auto_obstack : obstack > ~auto_obstack () > { obstack_free (this, NULL); } > > + DISABLE_COPY_AND_ASSIGN (auto_obstack); > + > /* Free all memory in the obstack but leave it valid for further > allocation. */ > void clear () > -- > 2.17.2 > >