From: Luis Machado <luis.machado@linaro.org>
To: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 5/8] Add per-unit obstack
Date: Tue, 11 Feb 2020 10:34:00 -0000 [thread overview]
Message-ID: <c42ce6f2-95af-bf97-28a8-2ef9ed5b9f84@linaro.org> (raw)
In-Reply-To: <20200208152758.29385-6-tom@tromey.com>
On 2/8/20 12:27 PM, Tom Tromey wrote:
> This adds an auto_obstack to the DWARF frame comp_unit object, and
> then changes the remaining code here to use the comp_unit obstack
> rather than the objfile obstack.
>
> At this point, all the storage for frame data is self-contained --
> that is, it is independent of the objfile.
>
> gdb/ChangeLog
> 2020-02-08 Tom Tromey <tom@tromey.com>
>
> * dwarf2/frame.c (struct comp_unit) <obstack>: New member.
> (decode_frame_entry_1): Use the comp_unit obstack.
>
> Change-Id: I8a1af090bcc2811762a38afbbea1512be7d952fb
> ---
> gdb/ChangeLog | 5 +++++
> gdb/dwarf2/frame.c | 7 +++++--
> 2 files changed, 10 insertions(+), 2 deletions(-)
>
> diff --git a/gdb/dwarf2/frame.c b/gdb/dwarf2/frame.c
> index 0e74b8e7e68..7e1a744513b 100644
> --- a/gdb/dwarf2/frame.c
> +++ b/gdb/dwarf2/frame.c
> @@ -158,6 +158,9 @@ struct comp_unit
>
> /* The FDE table. */
> dwarf2_fde_table fde_table;
> +
> + /* Hold data used by this module. */
> + auto_obstack obstack;
> };
>
> static struct dwarf2_fde *dwarf2_frame_find_fde (CORE_ADDR *pc,
> @@ -1771,7 +1774,7 @@ decode_frame_entry_1 (struct comp_unit *unit, const gdb_byte *start,
> if (find_cie (cie_table, cie_pointer))
> return end;
>
> - cie = XOBNEW (&unit->objfile->objfile_obstack, struct dwarf2_cie);
> + cie = XOBNEW (&unit->obstack, struct dwarf2_cie);
> cie->initial_instructions = NULL;
> cie->cie_pointer = cie_pointer;
>
> @@ -1950,7 +1953,7 @@ decode_frame_entry_1 (struct comp_unit *unit, const gdb_byte *start,
> if (cie_pointer >= unit->dwarf_frame_size)
> return NULL;
>
> - fde = XOBNEW (&unit->objfile->objfile_obstack, struct dwarf2_fde);
> + fde = XOBNEW (&unit->obstack, struct dwarf2_fde);
> fde->cie = find_cie (cie_table, cie_pointer);
> if (fde->cie == NULL)
> {
>
LGTM.
next prev parent reply other threads:[~2020-02-11 10:34 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-08 15:28 [PATCH 0/8] Share DWARF frame information across inferiors Tom Tromey
2020-02-08 15:28 ` [PATCH 8/8] Move the frame data to the BFD when possible Tom Tromey
2020-02-11 10:45 ` Luis Machado
2020-02-12 0:31 ` Tom Tromey
2020-11-14 3:31 ` Simon Marchi
2020-02-08 15:28 ` [PATCH 3/8] Change fde table to a vector Tom Tromey
[not found] ` <5a373a74-9283-5d82-a22d-7a2606a4d3f5@linaro.org>
2020-02-12 0:29 ` Tom Tromey
2020-02-12 3:28 ` Simon Marchi
2020-02-12 3:33 ` Simon Marchi
2020-02-12 22:36 ` Tom Tromey
2020-02-12 22:47 ` Simon Marchi
2020-02-08 15:28 ` [PATCH 4/8] Store the comp_unit instead of the FDE table Tom Tromey
2020-02-09 23:56 ` Christian Biesinger via gdb-patches
2020-02-12 0:19 ` Tom Tromey
2020-02-11 10:32 ` Luis Machado
2020-02-12 0:20 ` Tom Tromey
2020-02-12 3:36 ` Simon Marchi
2020-02-12 22:20 ` Tom Tromey
2020-02-08 15:28 ` [PATCH 7/8] Remove the objfile backlink from comp_unit Tom Tromey
2020-02-09 23:56 ` Christian Biesinger via gdb-patches
2020-02-12 0:26 ` Tom Tromey
2020-02-11 10:40 ` Luis Machado
2020-02-08 15:28 ` [PATCH 6/8] Remove a use of the comp_unit backlink Tom Tromey
2020-02-08 15:28 ` [PATCH 2/8] Dont' allow copying of auto_obstack Tom Tromey
2020-02-09 23:56 ` Christian Biesinger via gdb-patches
2020-02-12 0:16 ` Tom Tromey
2020-02-12 0:53 ` Simon Marchi
2020-02-12 1:01 ` Tom Tromey
2020-02-08 15:28 ` [PATCH 5/8] Add per-unit obstack Tom Tromey
2020-02-11 10:34 ` Luis Machado [this message]
2020-02-12 3:53 ` Simon Marchi
2020-02-12 22:41 ` Tom Tromey
2020-02-12 22:48 ` Simon Marchi
2020-02-12 22:51 ` Tom Tromey
2020-02-08 15:28 ` [PATCH 1/8] Don't forward-declare struct objfile in frame.h Tom Tromey
2020-02-12 0:51 ` Simon Marchi
2020-02-12 1:59 ` Tom Tromey
2020-02-08 15:29 ` [PATCH 0/8] Share DWARF frame information across inferiors Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c42ce6f2-95af-bf97-28a8-2ef9ed5b9f84@linaro.org \
--to=luis.machado@linaro.org \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox