From: Tom Tromey <tom@tromey.com>
To: Simon Marchi <simark@simark.ca>
Cc: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 4/8] Store the comp_unit instead of the FDE table
Date: Wed, 12 Feb 2020 22:20:00 -0000 [thread overview]
Message-ID: <87d0ajsb19.fsf@tromey.com> (raw)
In-Reply-To: <3e7284ad-e16a-062a-1084-fad37550c27f@simark.ca> (Simon Marchi's message of "Tue, 11 Feb 2020 22:36:51 -0500")
>>>>> "Simon" == Simon Marchi <simark@simark.ca> writes:
>> - unit = XOBNEW (&objfile->objfile_obstack, comp_unit);
>> + unit = new comp_unit;
Simon> Not mandatory, but I'd suggest using an std::unique_ptr here, to hold this
Simon> variable, and then "release" it into the per-objfile map (since it can only
Simon> hold bare pointers).
Good idea, I did this.
Tom
next prev parent reply other threads:[~2020-02-12 22:20 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-08 15:28 [PATCH 0/8] Share DWARF frame information across inferiors Tom Tromey
2020-02-08 15:28 ` [PATCH 1/8] Don't forward-declare struct objfile in frame.h Tom Tromey
2020-02-12 0:51 ` Simon Marchi
2020-02-12 1:59 ` Tom Tromey
2020-02-08 15:28 ` [PATCH 5/8] Add per-unit obstack Tom Tromey
2020-02-11 10:34 ` Luis Machado
2020-02-12 3:53 ` Simon Marchi
2020-02-12 22:41 ` Tom Tromey
2020-02-12 22:48 ` Simon Marchi
2020-02-12 22:51 ` Tom Tromey
2020-02-08 15:28 ` [PATCH 2/8] Dont' allow copying of auto_obstack Tom Tromey
2020-02-09 23:56 ` Christian Biesinger via gdb-patches
2020-02-12 0:16 ` Tom Tromey
2020-02-12 0:53 ` Simon Marchi
2020-02-12 1:01 ` Tom Tromey
2020-02-08 15:28 ` [PATCH 6/8] Remove a use of the comp_unit backlink Tom Tromey
2020-02-08 15:28 ` [PATCH 7/8] Remove the objfile backlink from comp_unit Tom Tromey
2020-02-09 23:56 ` Christian Biesinger via gdb-patches
2020-02-12 0:26 ` Tom Tromey
2020-02-11 10:40 ` Luis Machado
2020-02-08 15:28 ` [PATCH 4/8] Store the comp_unit instead of the FDE table Tom Tromey
2020-02-09 23:56 ` Christian Biesinger via gdb-patches
2020-02-12 0:19 ` Tom Tromey
2020-02-11 10:32 ` Luis Machado
2020-02-12 0:20 ` Tom Tromey
2020-02-12 3:36 ` Simon Marchi
2020-02-12 22:20 ` Tom Tromey [this message]
2020-02-08 15:28 ` [PATCH 3/8] Change fde table to a vector Tom Tromey
[not found] ` <5a373a74-9283-5d82-a22d-7a2606a4d3f5@linaro.org>
2020-02-12 0:29 ` Tom Tromey
2020-02-12 3:28 ` Simon Marchi
2020-02-12 3:33 ` Simon Marchi
2020-02-12 22:36 ` Tom Tromey
2020-02-12 22:47 ` Simon Marchi
2020-02-08 15:28 ` [PATCH 8/8] Move the frame data to the BFD when possible Tom Tromey
2020-02-11 10:45 ` Luis Machado
2020-02-12 0:31 ` Tom Tromey
2020-11-14 3:31 ` Simon Marchi
2020-02-08 15:29 ` [PATCH 0/8] Share DWARF frame information across inferiors Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d0ajsb19.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=simark@simark.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox