From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 112205 invoked by alias); 12 Feb 2020 22:20:23 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 112189 invoked by uid 89); 12 Feb 2020 22:20:22 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-8.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy= X-HELO: gateway21.websitewelcome.com Received: from gateway21.websitewelcome.com (HELO gateway21.websitewelcome.com) (192.185.45.175) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 12 Feb 2020 22:20:21 +0000 Received: from cm10.websitewelcome.com (cm10.websitewelcome.com [100.42.49.4]) by gateway21.websitewelcome.com (Postfix) with ESMTP id 0B089400CBD2B for ; Wed, 12 Feb 2020 16:20:20 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 20MljZnBEEfyq20MmjjSzX; Wed, 12 Feb 2020 16:20:20 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=ci9UY27W+jVpBHu+C6Vkn0BDgN9avZwMWIZaVWFFGfA=; b=DtMtkR/eNIKY1YJArP6WH2gR3f Ths8wDxkm8YYENKc9ysF2x0B+lVc6UDTQ6gpFN5v+/tF1YvjY9MXoGhO/lq/h8+/2I1UiU68HGWnr yMEX3Uggl3V1M5dt4YfQpSh16; Received: from 75-166-123-50.hlrn.qwest.net ([75.166.123.50]:56182 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1j20Ml-001Vys-N6; Wed, 12 Feb 2020 15:20:19 -0700 From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH 4/8] Store the comp_unit instead of the FDE table References: <20200208152758.29385-1-tom@tromey.com> <20200208152758.29385-5-tom@tromey.com> <3e7284ad-e16a-062a-1084-fad37550c27f@simark.ca> Date: Wed, 12 Feb 2020 22:20:00 -0000 In-Reply-To: <3e7284ad-e16a-062a-1084-fad37550c27f@simark.ca> (Simon Marchi's message of "Tue, 11 Feb 2020 22:36:51 -0500") Message-ID: <87d0ajsb19.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2020-02/txt/msg00465.txt.bz2 >>>>> "Simon" == Simon Marchi writes: >> - unit = XOBNEW (&objfile->objfile_obstack, comp_unit); >> + unit = new comp_unit; Simon> Not mandatory, but I'd suggest using an std::unique_ptr here, to hold this Simon> variable, and then "release" it into the per-objfile map (since it can only Simon> hold bare pointers). Good idea, I did this. Tom