Re: [PATCH v2] Change boolean options to bool instead of int

["Christian Biesinger via gdb-patches" <gdb-patches@sourceware.org>]

On Tue, Sep 17, 2019 at 12:23 PM Christian Biesinger
<cbiesinger@google.com> wrote:
>
> On Tue, Sep 17, 2019 at 3:02 AM Simon Marchi <simark@simark.ca> wrote:
> > This also reminded me that there are some uses of add_setshow_boolean_cmd in native files.
> > Doing a
> >
> >   grep add_setshow_boolean_cmd *-nat.c
> >
> > to find them would be a good start, but actually all the files listed in configure.nat should
> > be considered, as they may not be included in your build.
> >
> > For those native files, you can try to build test some if you want to, but you probably won't
> > be able to build all of them.  That is fine, just do a best effort of changing the spots you
> > find.
>
> I wasn't able to build any of them (as "make -C obj/gdb
> mips-linux-nat.o, etc.). But I did update what I could. I did also go
> through the other files in configure.nat and changed what I could
> find.
>
> (note that some of the *-nat.c files are referencing show_debug_regs
> which is in a common file, so they didn't need changing)

Per advice from Simon on IRC, I successfully crosscompiled the latest
version of the patch to these targets:
arm-linux-gnueabihf, mips-linux-gnu, powerpc-linux-gnu,
s390x-linux-gnu, x86_64-w64-mingw32

I don't have a way to compile for darwin, fbsd, obsd, gnu, I think.

Christian


Christian