Re: [RFC] Change boolean options to bool instead of int

[Simon Marchi <simark@simark.ca>]

On 2019-09-15 4:33 a.m., Christian Biesinger via gdb-patches wrote:
> [Before I write a huge changelog entry for this... would this be acceptable
> in principle?]
> 
> This is for add_setshow_boolean_cmd as well as the gdb::option interface.

Hi Christian,

I don't really see any problem with doing this, it seems like the natural thing to do.

There are still some globals that are initialized with 0 or 1 instead of false or true.
You can find them with:

  $ grep 'bool .* = [01];' *.c */*.c

To generate a big ChangeLog entry like this, you can try using one of the various
scripts that try to generate a ChangeLog entry from a diff, like the one from gcc:

  https://github.com/gcc-mirror/gcc/blob/master/contrib/mklog

It might do half of the job automatically.

I opened files at random to get a feel of the patch and happened to notice this:

> diff --git a/gdb/command.h b/gdb/command.h
> index 2c608048d54..29b99333946 100644
> --- a/gdb/command.h
> +++ b/gdb/command.h
> @@ -62,8 +62,8 @@ cmd_types;
>  /* Types of "set" or "show" command.  */
>  typedef enum var_types
>    {
> -    /* "on" or "off".  *VAR is an integer which is nonzero for on,
> -       zero for off.  */
> +    /* "on" or "off".  *VAR is an bool which is true for on,
> +       false for off.  */

"is an bool" -> "is a bool"

Simon