From: Simon Marchi <simark@simark.ca>
To: Andrew Burgess <andrew.burgess@embecosm.com>,
Christian Biesinger <cbiesinger@google.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PP?] Re: [RFC] Change boolean options to bool instead of int
Date: Mon, 16 Sep 2019 17:04:00 -0000 [thread overview]
Message-ID: <9b9011cb-0841-9315-7478-aa99d39cbf2a@simark.ca> (raw)
In-Reply-To: <20190915232847.GA6076@embecosm.com>
On 2019-09-15 7:28 p.m., Andrew Burgess wrote:
>> @@ -842,6 +845,7 @@ captured_main_1 (struct captured_main_args *context)
>> gdb_program_name);
>> }
>> }
>> + write_files = write_files_1;
>
> I would prefer to see conversions from int to bool be made explicit:
>
> write_files = (write_files_1 != 0);
>
> but if you strongly oppose then I don't care that much.
I agree, it goes in line with our rule of explicitly using
if (some_int != 0)
rather than
if (some_int)
Simon
prev parent reply other threads:[~2019-09-16 17:04 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-15 8:34 Christian Biesinger via gdb-patches
2019-09-15 23:10 ` Simon Marchi
2019-09-16 0:22 ` Christian Biesinger via gdb-patches
2019-09-16 17:06 ` Simon Marchi
2019-09-15 23:29 ` Andrew Burgess
2019-09-16 3:09 ` Christian Biesinger via gdb-patches
2019-09-16 3:10 ` [PATCH v2] " Christian Biesinger via gdb-patches
2019-09-16 17:32 ` Andrew Burgess
2019-09-16 18:03 ` Simon Marchi
2019-09-17 3:23 ` Christian Biesinger via gdb-patches
2019-09-17 3:26 ` [PATCH v3] " Christian Biesinger via gdb-patches
2019-09-17 12:43 ` Simon Marchi
2019-09-18 0:34 ` [PATCH v4] " Christian Biesinger via gdb-patches
2019-09-17 5:03 ` [PATCH v2] " Christian Biesinger via gdb-patches
2019-09-16 17:04 ` Simon Marchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9b9011cb-0841-9315-7478-aa99d39cbf2a@simark.ca \
--to=simark@simark.ca \
--cc=andrew.burgess@embecosm.com \
--cc=cbiesinger@google.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox