From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-158819-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 27462 invoked by alias); 16 Sep 2019 17:04:47 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 27454 invoked by uid 89); 16 Sep 2019 17:04:47 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-6.6 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 spammy=our
X-HELO: simark.ca
Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 16 Sep 2019 17:04:43 +0000
Received: from [172.16.0.120] (192-222-181-218.qc.cable.ebox.net [192.222.181.218])	(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))	(No client certificate requested)	by simark.ca (Postfix) with ESMTPSA id ED9DC1E573;	Mon, 16 Sep 2019 13:04:41 -0400 (EDT)
Subject: Re: [PP?] Re: [RFC] Change boolean options to bool instead of int
To: Andrew Burgess <andrew.burgess@embecosm.com>, Christian Biesinger <cbiesinger@google.com>
Cc: gdb-patches@sourceware.org
References: <20190915083353.33228-1-cbiesinger@google.com> <20190915232847.GA6076@embecosm.com>
From: Simon Marchi <simark@simark.ca>
Message-ID: <9b9011cb-0841-9315-7478-aa99d39cbf2a@simark.ca>
Date: Mon, 16 Sep 2019 17:04:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0
MIME-Version: 1.0
In-Reply-To: <20190915232847.GA6076@embecosm.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-SW-Source: 2019-09/txt/msg00286.txt.bz2

On 2019-09-15 7:28 p.m., Andrew Burgess wrote:
>> @@ -842,6 +845,7 @@ captured_main_1 (struct captured_main_args *context)
>>  		   gdb_program_name);
>>  	  }
>>        }
>> +    write_files = write_files_1;
> 
> I would prefer to see conversions from int to bool be made explicit:
> 
>   write_files = (write_files_1 != 0);
> 
> but if you strongly oppose then I don't care that much.

I agree, it goes in line with our rule of explicitly using

  if (some_int != 0)

rather than

  if (some_int)

Simon