From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26433 invoked by alias); 17 Sep 2019 05:03:47 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 26424 invoked by uid 89); 17 Sep 2019 05:03:47 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-18.3 required=5.0 tests=AWL,BAYES_00,ENV_AND_HDR_SPF_MATCH,RCVD_IN_DNSWL_NONE,SPF_PASS,USER_IN_DEF_SPF_WL autolearn=ham version=3.3.1 spammy=HX-Spam-Relays-External:209.85.210.68, HX-Languages-Length:1378, H*RU:209.85.210.68 X-HELO: mail-ot1-f68.google.com Received: from mail-ot1-f68.google.com (HELO mail-ot1-f68.google.com) (209.85.210.68) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 17 Sep 2019 05:03:45 +0000 Received: by mail-ot1-f68.google.com with SMTP id e11so736633otl.5 for ; Mon, 16 Sep 2019 22:03:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=FPR58fKmt51sLnjZijF8zenoUedujc0IXAKkAnOo75Y=; b=GrQyQaQIGr7J0jABHccbTLf5amxl9lUC70DkXmLcWjzIcEJ9gGVhs1C3q0HW+biROs Otko3TFCkwH8dwtNdFl+P3gW5sA60FvZ4m1NVnnyqko5aaGC1/DoFu+Gy/XwcWxOAsC6 OoD8f9bBWf1S2Kcuyv9hTvlyScK2HD9V+sK7vqDiXK+0JPAE7tC7K2oM3qQh5cMJfVHp d5jW1GmG5iCNEnDVVVrI1jOEHAp/76gvO0GV+YBNzYzOWA07trv2mrlJF4AWhd+iJRSF dtq6Qx97AVZXTKyA0K8r0n+c3oAjYgyvi6YSkW/ra+hT9qPz7yjhIqIWdlP+xu8i8ijd H0cA== MIME-Version: 1.0 References: <20190916031013.253592-1-cbiesinger@google.com> <7bf0445c-deb4-d1b1-3d3b-66de3498b2a7@simark.ca> In-Reply-To: From: "Christian Biesinger via gdb-patches" Reply-To: Christian Biesinger Date: Tue, 17 Sep 2019 05:03:00 -0000 Message-ID: Subject: Re: [PATCH v2] Change boolean options to bool instead of int To: Simon Marchi Cc: gdb-patches Content-Type: text/plain; charset="UTF-8" X-IsSubscribed: yes X-SW-Source: 2019-09/txt/msg00309.txt.bz2 On Tue, Sep 17, 2019 at 12:23 PM Christian Biesinger wrote: > > On Tue, Sep 17, 2019 at 3:02 AM Simon Marchi wrote: > > This also reminded me that there are some uses of add_setshow_boolean_cmd in native files. > > Doing a > > > > grep add_setshow_boolean_cmd *-nat.c > > > > to find them would be a good start, but actually all the files listed in configure.nat should > > be considered, as they may not be included in your build. > > > > For those native files, you can try to build test some if you want to, but you probably won't > > be able to build all of them. That is fine, just do a best effort of changing the spots you > > find. > > I wasn't able to build any of them (as "make -C obj/gdb > mips-linux-nat.o, etc.). But I did update what I could. I did also go > through the other files in configure.nat and changed what I could > find. > > (note that some of the *-nat.c files are referencing show_debug_regs > which is in a common file, so they didn't need changing) Per advice from Simon on IRC, I successfully crosscompiled the latest version of the patch to these targets: arm-linux-gnueabihf, mips-linux-gnu, powerpc-linux-gnu, s390x-linux-gnu, x86_64-w64-mingw32 I don't have a way to compile for darwin, fbsd, obsd, gnu, I think. Christian Christian