From: "Christian Biesinger via gdb-patches" <gdb-patches@sourceware.org>
To: Aaron Merey <amerey@redhat.com>
Cc: gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH] gdb: Check for nullptr when computing srcpath
Date: Thu, 27 Feb 2020 19:33:00 -0000 [thread overview]
Message-ID: <CAPTJ0XE7Wdq0YtbmbHPiRML9LJBObSXO6Xzcuyb7ovfgQjP3ZA@mail.gmail.com> (raw)
In-Reply-To: <CAJDtP-Q8E=Kyf4n8-o3OJ=gKjR4e+sHKTA0FbL0h8uTqF-NmnQ@mail.gmail.com>
+ if (build_id != nullptr && srcpath.size () > 0)
I usually prefer !srcpath.empty ()
Also, I would like to second simark's suggestion for git-send-email!
Christian
On Thu, Feb 27, 2020 at 12:00 PM Aaron Merey <amerey@redhat.com> wrote:
>
>
next prev parent reply other threads:[~2020-02-27 19:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-27 18:00 Aaron Merey
2020-02-27 19:18 ` Simon Marchi
2020-02-27 19:20 ` Simon Marchi
2020-02-27 19:33 ` Christian Biesinger via gdb-patches [this message]
2020-02-27 22:12 ` Aaron Merey
2020-02-27 23:37 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPTJ0XE7Wdq0YtbmbHPiRML9LJBObSXO6Xzcuyb7ovfgQjP3ZA@mail.gmail.com \
--to=gdb-patches@sourceware.org \
--cc=amerey@redhat.com \
--cc=cbiesinger@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox