Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Simon Marchi <simark@simark.ca>
To: Aaron Merey <amerey@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb: Check for nullptr when computing srcpath
Date: Thu, 27 Feb 2020 19:18:00 -0000	[thread overview]
Message-ID: <4fa9a257-f805-c9b7-cae7-8c13ea438e14@simark.ca> (raw)
In-Reply-To: <CAJDtP-Q8E=Kyf4n8-o3OJ=gKjR4e+sHKTA0FbL0h8uTqF-NmnQ@mail.gmail.com>

On 2020-02-27 1:00 p.m., Aaron Merey wrote:
> 

Hi Aaron,

Please provide in the commit message an explanation of what this fixes, including
how to reproduce the crash.  Since this fixes the execution of an existing test
case, you can include the "make check" command line used to run it, like:

  make check TESTS="gdb.dwarf2/dw2-ranges-base"

Simon


  reply	other threads:[~2020-02-27 19:18 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-27 18:00 Aaron Merey
2020-02-27 19:18 ` Simon Marchi [this message]
2020-02-27 19:20   ` Simon Marchi
2020-02-27 19:33 ` Christian Biesinger via gdb-patches
2020-02-27 22:12   ` Aaron Merey
2020-02-27 23:37     ` Simon Marchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4fa9a257-f805-c9b7-cae7-8c13ea438e14@simark.ca \
    --to=simark@simark.ca \
    --cc=amerey@redhat.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox