Re: [PATCH] gdb: Check for nullptr when computing srcpath

[Simon Marchi <simark@simark.ca>]

On 2020-02-27 5:11 p.m., Aaron Merey wrote:
> On Thu, Feb 27, 2020 at 2:18 PM Simon Marchi <simark@simark.ca> wrote:
>> Please provide in the commit message an explanation of what this fixes, including
>> how to reproduce the crash.  Since this fixes the execution of an existing test
>> case, you can include the "make check" command line used to run it, like:
>>
>>   make check TESTS="gdb.dwarf2/dw2-ranges-base"
> 
> Fixed.
> 
>> Also, do you think you'd be able to send your patches using git-send-email?  That makes
>> it much easier to read and comment on.
> 
> Sure.
> 
> On Thu, Feb 27, 2020 at 2:33 PM Christian Biesinger <cbiesinger@google.com> wrote:
>> +   if (build_id != nullptr && srcpath.size () > 0)
>>
>> I usually prefer !srcpath.empty ()
> 
> Fixed.
> 
> Aaron
> 
> 
> From d048f84f027006782cd96dc66a10477ed5a78243 Mon Sep 17 00:00:00 2001
> From: Aaron Merey <amerey@redhat.com>
> Date: Thu, 27 Feb 2020 15:51:11 -0500
> Subject: [PATCH] gdb: Check for nullptr when computing srcpath
> 
> This fixes a regression caused by commit 0d79cdc494d5:
> 
>   $ make check TESTS="gdb.dwarf2/dw2-ranges-base.exp"
>   [...]
>   ERROR: GDB process no longer exists
> 
> This error is caused by an abort during the computation of srcpath
> when SYMTAB_DIRNAME (s) == NULL.
> 
> Computing srcpath only when SYMTAB_DIRNAME (s) is not NULL fixes this
> error. Also change the condition for calling debuginfod_source_query
> to include whether srcpath could be computed.
> 
> gdb/ChangeLog:
> 
> 2020-02-27  Aaron Merey  <amerey@redhat.com>
> 
>         * source.c (open_source_file): Check for nullptr when computing
>         srcpath.

Thanks, that LGTM.

Simon