From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-164721-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 22736 invoked by alias); 27 Feb 2020 19:33:44 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 22722 invoked by uid 89); 27 Feb 2020 19:33:44 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-16.9 required=5.0 tests=AWL,BAYES_00,ENV_AND_HDR_SPF_MATCH,RCVD_IN_DNSWL_NONE,SPF_PASS,USER_IN_DEF_SPF_WL autolearn=ham version=3.3.1 spammy=HX-Received:6288
X-HELO: mail-ot1-f66.google.com
Received: from mail-ot1-f66.google.com (HELO mail-ot1-f66.google.com) (209.85.210.66) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 27 Feb 2020 19:33:42 +0000
Received: by mail-ot1-f66.google.com with SMTP id r16so323033otd.2        for <gdb-patches@sourceware.org>; Thu, 27 Feb 2020 11:33:42 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;        d=google.com; s=20161025;        h=mime-version:references:in-reply-to:from:date:message-id:subject:to         :cc;        bh=YBazj9GgodvcF8bTes8Pqjh6gu+ekAPiXyeMGSSbdfA=;        b=dgRcUbqAJK+M/6oyJwQ2pK+1uP21p7AdckJUDdkS++Jm+OaV06lSLyizVCLcLI62aW         9SUVX0YLULAjXYqUcMFjN+SRjC8puHhXGJ7Uj4Mc3puuRF62xUqplZ6M62g7dDONtNR0         kyqWcjDicDfwjKGoeGODmrB3ev7k/S5VRHUFGjZosTyOA6kuJwb4IX6PcEXWW+rgLL9O         vXgwvOyq+/zOafSFxvrUmfegN2T19/Qvdu6Yqy0J0vPA9K1CNDkEXzuCqy7520KuV7lw         4Ppq6gDJqJJMZ4AjixbZEKp98tRbBAFqgHIiW9u9gQjvC7BtUXxnxPgauGLuzq6juIt8         g7Gw==
MIME-Version: 1.0
References: <CAJDtP-Q8E=Kyf4n8-o3OJ=gKjR4e+sHKTA0FbL0h8uTqF-NmnQ@mail.gmail.com>
In-Reply-To: <CAJDtP-Q8E=Kyf4n8-o3OJ=gKjR4e+sHKTA0FbL0h8uTqF-NmnQ@mail.gmail.com>
From: "Christian Biesinger via gdb-patches" <gdb-patches@sourceware.org>
Reply-To: Christian Biesinger <cbiesinger@google.com>
Date: Thu, 27 Feb 2020 19:33:00 -0000
Message-ID: <CAPTJ0XE7Wdq0YtbmbHPiRML9LJBObSXO6Xzcuyb7ovfgQjP3ZA@mail.gmail.com>
Subject: Re: [PATCH] gdb: Check for nullptr when computing srcpath
To: Aaron Merey <amerey@redhat.com>
Cc: gdb-patches <gdb-patches@sourceware.org>
Content-Type: text/plain; charset="UTF-8"
X-IsSubscribed: yes
X-SW-Source: 2020-02/txt/msg01023.txt.bz2

+   if (build_id != nullptr && srcpath.size () > 0)

I usually prefer !srcpath.empty ()

Also, I would like to second simark's suggestion for git-send-email!

Christian

On Thu, Feb 27, 2020 at 12:00 PM Aaron Merey <amerey@redhat.com> wrote:
>
>