From: Will Newton <will.newton@linaro.org>
To: Tom Tromey <tromey@redhat.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
Patch Tracking <patches@linaro.org>
Subject: Re: [PATCH] gdb/testsuite/gdb.threads: Make sure TLS tests link against pthreads.
Date: Wed, 17 Jul 2013 20:17:00 -0000 [thread overview]
Message-ID: <CANu=Dmjo4J-Mxn4vzTqmgaS8i_1EAR_sZBjxt-Oyb3XE1AOiRA@mail.gmail.com> (raw)
In-Reply-To: <87ip09f3ta.fsf@fleche.redhat.com>
On 17 July 2013 19:18, Tom Tromey <tromey@redhat.com> wrote:
>
> >>>>> "Will" == Will Newton <will.newton@linaro.org> writes:
>
> Will> int main(void)
> Will> {
> Will> - return 0;
> Will> + return pthread_self();
>
> I think it is possible according to POSIX for pthread_t to be a pointer
> type. It seems like it would be safer to just use a call to
> pthread_testcancel in all these tests.
Yes, that's true. I'll respin the patch, thanks for the review!
--
Will Newton
Toolchain Working Group, Linaro
prev parent reply other threads:[~2013-07-17 20:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-07 18:41 Will Newton
2013-06-11 23:39 ` Andrew Pinski
2013-06-12 10:26 ` Will Newton
2013-06-12 11:57 ` Joel Brobecker
2013-07-17 18:16 ` Tom Tromey
2013-07-17 18:18 ` Tom Tromey
2013-07-17 19:05 ` Mark Kettenis
2013-07-17 20:17 ` Will Newton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANu=Dmjo4J-Mxn4vzTqmgaS8i_1EAR_sZBjxt-Oyb3XE1AOiRA@mail.gmail.com' \
--to=will.newton@linaro.org \
--cc=gdb-patches@sourceware.org \
--cc=patches@linaro.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox