From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32320 invoked by alias); 17 Jul 2013 20:17:59 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 32305 invoked by uid 89); 17 Jul 2013 20:17:59 -0000 X-Spam-SWARE-Status: No, score=-3.0 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,RDNS_NONE autolearn=ham version=3.3.1 Received: from Unknown (HELO mail-ie0-f180.google.com) (209.85.223.180) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Wed, 17 Jul 2013 20:17:58 +0000 Received: by mail-ie0-f180.google.com with SMTP id f4so5087362iea.11 for ; Wed, 17 Jul 2013 13:17:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:x-gm-message-state; bh=pCXa9Hl199TFyiw8xcxnoK+qDBLB31yrDqYxJCeXXbY=; b=fMRi5Sip7NRQ7sJX6RlOcrpsraXMYHra49gpcQ1NTcQFuRP9nyWLJ5gcb2fK7C8cVg JdHG/MLa1wOrmJ/UeP78PP+xyoV4gPXHplF6BSWDhI1WMYq/Kfz+bZ+F/lpeTG/w/YqE FwWaazNPmj5Outd3CAfwseGhzCAJOECGKsbffMxQLWb6F0RNfHgrZiHxMNeCuaySQEFd aS0WqmHPXCofuY5+ZaOEGU/C19aNCnIfygGNDeQ77Vo5crDqF5GRMg2n7sWIECTPAuB1 eBj/R2WvBA/89p8VLC4B5lxmQAQGWIJ+J+QXiO934PuJagIuWf/xZFWXWVNEfbB8JxPQ qzTg== MIME-Version: 1.0 X-Received: by 10.50.67.111 with SMTP id m15mr1857126igt.54.1374092271237; Wed, 17 Jul 2013 13:17:51 -0700 (PDT) Received: by 10.64.76.116 with HTTP; Wed, 17 Jul 2013 13:17:51 -0700 (PDT) In-Reply-To: <87ip09f3ta.fsf@fleche.redhat.com> References: <51B22910.7010208@linaro.org> <87ip09f3ta.fsf@fleche.redhat.com> Date: Wed, 17 Jul 2013 20:17:00 -0000 Message-ID: Subject: Re: [PATCH] gdb/testsuite/gdb.threads: Make sure TLS tests link against pthreads. From: Will Newton To: Tom Tromey Cc: "gdb-patches@sourceware.org" , Patch Tracking Content-Type: text/plain; charset=ISO-8859-1 X-Gm-Message-State: ALoCoQlF0brth6Ex+NVuJNSn55ceX7G4Cwp55sdX2+lnAhrkPfieXHzS9QtkgAGTu+fuVeEP2TDX X-SW-Source: 2013-07/txt/msg00431.txt.bz2 On 17 July 2013 19:18, Tom Tromey wrote: > > >>>>> "Will" == Will Newton writes: > > Will> int main(void) > Will> { > Will> - return 0; > Will> + return pthread_self(); > > I think it is possible according to POSIX for pthread_t to be a pointer > type. It seems like it would be safer to just use a call to > pthread_testcancel in all these tests. Yes, that's true. I'll respin the patch, thanks for the review! -- Will Newton Toolchain Working Group, Linaro