Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Will Newton <will.newton@linaro.org>
To: gdb-patches@sourceware.org
Cc: patches@linaro.org
Subject: [PATCH] gdb/testsuite/gdb.threads: Make sure TLS tests link against pthreads.
Date: Fri, 07 Jun 2013 18:41:00 -0000	[thread overview]
Message-ID: <51B22910.7010208@linaro.org> (raw)


On Ubuntu the compiler passes --as-needed to the linker which means
no DT_NEEDED entry is added for libpthread when building the TLS
tests. This causes the test to fail as a libpthread is required to
look up TLS variables. Add some calls to pthread functions to make
sure libpthread is linked.

gdb/testsuite/ChangeLog:

2013-06-07  Will Newton  <will.newton@linaro.org>

	* gdb.threads/tls-nodebug.c: Call pthread_self to ensure
	the test is linked against pthreads.
	* gdb.threads/tls-var-main.c: Likewise.
	* gdb.threads/tls-shared.c: Call pthread_testcancel to
	ensure the test is linked against pthreads.
---
 gdb/testsuite/gdb.threads/tls-nodebug.c  | 2 +-
 gdb/testsuite/gdb.threads/tls-shared.c   | 4 ++++
 gdb/testsuite/gdb.threads/tls-var-main.c | 4 +++-
 3 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/gdb/testsuite/gdb.threads/tls-nodebug.c b/gdb/testsuite/gdb.threads/tls-nodebug.c
index 73d96f0..10aa8c8 100644
--- a/gdb/testsuite/gdb.threads/tls-nodebug.c
+++ b/gdb/testsuite/gdb.threads/tls-nodebug.c
@@ -6,5 +6,5 @@ __thread int thread_local = 42;

 int main(void)
 {
-  return 0;
+  return pthread_self();
 }
diff --git a/gdb/testsuite/gdb.threads/tls-shared.c b/gdb/testsuite/gdb.threads/tls-shared.c
index d4f8e5c..1ef7949 100644
--- a/gdb/testsuite/gdb.threads/tls-shared.c
+++ b/gdb/testsuite/gdb.threads/tls-shared.c
@@ -1,6 +1,10 @@
+
+#include <pthread.h>
+
 __thread int i_tls = 1;
 int foo ()
 {
+  pthread_testcancel();
   return i_tls;
 }

diff --git a/gdb/testsuite/gdb.threads/tls-var-main.c b/gdb/testsuite/gdb.threads/tls-var-main.c
index 34a2522..4728ea3 100644
--- a/gdb/testsuite/gdb.threads/tls-var-main.c
+++ b/gdb/testsuite/gdb.threads/tls-var-main.c
@@ -15,8 +15,10 @@
    You should have received a copy of the GNU General Public License
    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */

+#include <pthread.h>
+
 int
 main (void)
 {
-  return 0;
+  return pthread_self();
 }
-- 
1.8.1.4


             reply	other threads:[~2013-06-07 18:40 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-07 18:41 Will Newton [this message]
2013-06-11 23:39 ` Andrew Pinski
2013-06-12 10:26   ` Will Newton
2013-06-12 11:57     ` Joel Brobecker
2013-07-17 18:16   ` Tom Tromey
2013-07-17 18:18 ` Tom Tromey
2013-07-17 19:05   ` Mark Kettenis
2013-07-17 20:17   ` Will Newton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51B22910.7010208@linaro.org \
    --to=will.newton@linaro.org \
    --cc=gdb-patches@sourceware.org \
    --cc=patches@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox