From: Joel Brobecker <brobecker@adacore.com>
To: Will Newton <will.newton@linaro.org>
Cc: Andrew Pinski <pinskia@gmail.com>,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
Patch Tracking <patches@linaro.org>
Subject: Re: [PATCH] gdb/testsuite/gdb.threads: Make sure TLS tests link against pthreads.
Date: Wed, 12 Jun 2013 11:57:00 -0000 [thread overview]
Message-ID: <20130612102642.GO3969@adacore.com> (raw)
In-Reply-To: <CANu=DmhfirgXvZC9txdj+=uSV3mpbOY2j7EQQzE7BxisGoZp8Q@mail.gmail.com>
> > I think this should be an debian/Ubuntu local only patch as the
> > default for FSF GCC/binutils is not to pass --as-needed.
>
> I admit the change is a little, erm, weird, but my hope was to avoid
> causing pain to people who build gdb on Ubuntu. This isn't just Ubunto
> or Debian developers but Ubuntu or Debian users that happen to have
> downloaded a gdb tarball from gnu.org. Similar test failures in
> binutils have been worked around by adding -Wl,--no-as-needed which we
> could also do here, but I was concerned that this may break non-gcc
> compilers.
I tend to agree that it can be potentially useful, and since it does
not appear to be very disruptive, I find it acceptable in principle.
I just haven't had time to look into it in more details...
--
Joel
next prev parent reply other threads:[~2013-06-12 10:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-07 18:41 Will Newton
2013-06-11 23:39 ` Andrew Pinski
2013-06-12 10:26 ` Will Newton
2013-06-12 11:57 ` Joel Brobecker [this message]
2013-07-17 18:16 ` Tom Tromey
2013-07-17 18:18 ` Tom Tromey
2013-07-17 19:05 ` Mark Kettenis
2013-07-17 20:17 ` Will Newton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130612102642.GO3969@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=patches@linaro.org \
--cc=pinskia@gmail.com \
--cc=will.newton@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox